Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pkre should accept compiled re & flexible actual #409

Open
robnagler opened this issue Oct 13, 2023 · 0 comments
Open

pkre should accept compiled re & flexible actual #409

robnagler opened this issue Oct 13, 2023 · 0 comments
Milestone

Comments

@robnagler
Copy link
Member

robnagler commented Oct 13, 2023

ValueError: cannot process flags argument with a compiled pattern

Test on re.Pattern and otherwise compile. Possibly deprecate passing flags to pkre to normalize for #401

actual might be bytes so convert that. If it isn't bytes, it could be converted to json to do the comparison.

@robnagler robnagler changed the title pkre should accept compiled re pkre should accept compiled re & flexible actual Feb 15, 2024
@robnagler robnagler added this to the any milestone Mar 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant