-
Notifications
You must be signed in to change notification settings - Fork 145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ol-stac migration #531 #535
base: main
Are you sure you want to change the base?
Conversation
13d5ae5
to
bcbbf3a
Compare
great :) |
@m-mohr FYI this branch allow correctly stream from a local titiler, but not able to show any collection footprint served by eoAPI pgstac compose (removing stac-browser). Footprint is shown only for Items. |
cbc9cb2
to
e9e66ce
Compare
@luipir Your problem should be fixed. Generally, I've tried to better document above what known issues exist, all other functionality should be back and working. You can start tests now. |
ccd96be
to
6baf41f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@m-mohr this is far beyond my expertise. Do you need me to approve anyway?
Hi @m-mohr is it intentional that item submenu now will open on the right of the ol-map? In main it will open just where the item BBOX is visualised (or where collection is visualised, I do not remember correctly). Could it be considered a regression? p.s. rendering on Firefox anonymous windows with version 134.0.1 on Ubuntu if this could help |
Another observation that I realised only now that COG preview is working correctly: In my case is a light problem because API follow a different authorization pattern. |
No. I'll check whether the old behaviour is possible with OpenLayers. Due to WebGL rendering, it might be difficult though.
I'm not sure I fully understand what you are saying. |
not sure if it is a better rephrase of my question as been posted here where you already answered. |
This has been fixed, it shows now where the mouse click happened. It can't directly attach to the feature anymore as we support selecting multiple features now. Beforehand you could only select the topmost is multiple features were stacked over each other. Once the next ol-stac release is released, STAC Browser will also highlight the selected features in red again and have a bit of a hit tolerance to click smaller geometries easier. Thanks for the report @luipir . |
confirmed that it works now :)
:)
thank you for the bug fix and new features :) |
Implements/Fixes
Open issues:
Potential features to be considered:
Breaking changes:
maxPreviewsOnMap
buildTileUrlTemplate
default to null now. The function has a different signature now, an Asset object (see stac-js) is passed as only argument. No other parameters are passen. To get the absolute url for the URL constuction, use asset.getAbsoluteUrl()