Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ol-stac migration #531 #535

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

ol-stac migration #531 #535

wants to merge 4 commits into from

Conversation

m-mohr
Copy link
Collaborator

@m-mohr m-mohr commented Jan 14, 2025

Implements/Fixes

Open issues:

Potential features to be considered:

Breaking changes:

  • Removed maxPreviewsOnMap
  • buildTileUrlTemplate default to null now. The function has a different signature now, an Asset object (see stac-js) is passed as only argument. No other parameters are passen. To get the absolute url for the URL constuction, use asset.getAbsoluteUrl()
  • basemaps.config.js has a new format. Multiple basemaps per planet can be provided. The default behaviour of configureBasemap has changed, including a removal of the map parameter.

@m-mohr m-mohr added the mapping label Jan 14, 2025
@m-mohr m-mohr added this to the 3.4.0 milestone Jan 14, 2025
@m-mohr m-mohr force-pushed the ol-stac branch 2 times, most recently from 13d5ae5 to bcbbf3a Compare January 14, 2025 23:38
@luipir
Copy link

luipir commented Jan 16, 2025

great :)

@luipir
Copy link

luipir commented Jan 20, 2025

@m-mohr FYI this branch allow correctly stream from a local titiler, but not able to show any collection footprint served by eoAPI pgstac compose (removing stac-browser). Footprint is shown only for Items.

@m-mohr
Copy link
Collaborator Author

m-mohr commented Jan 25, 2025

@luipir Your problem should be fixed.

Generally, I've tried to better document above what known issues exist, all other functionality should be back and working. You can start tests now.

@m-mohr m-mohr self-assigned this Jan 27, 2025
@m-mohr m-mohr marked this pull request as ready for review January 27, 2025 23:26
Copy link
Collaborator

@p1d1d1 p1d1d1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@m-mohr this is far beyond my expertise. Do you need me to approve anyway?

@m-mohr
Copy link
Collaborator Author

m-mohr commented Jan 28, 2025

@p1d1d1 No, not at all. Please check #548 though.

@luipir
Copy link

luipir commented Jan 28, 2025

Hi @m-mohr is it intentional that item submenu now will open on the right of the ol-map? In main it will open just where the item BBOX is visualised (or where collection is visualised, I do not remember correctly). Could it be considered a regression?
Screenshot from 2025-01-28 10-36-22

p.s. rendering on Firefox anonymous windows with version 134.0.1 on Ubuntu if this could help

@luipir
Copy link

luipir commented Jan 28, 2025

Another observation that I realised only now that COG preview is working correctly:
Item preview in a collection view DO NOT use buildTileUrlTemplate to render it, but just direct COG read.
In the screenshot on the left the collection view with inner items rendered directly without using buildTileUrlTemplate and on the right the item view that yes it uses the buildTileUrlTemplate.

Screenshot from 2025-01-28 10-56-23

In my case is a light problem because API follow a different authorization pattern.
Is there a reason why collection view do not use TileLayer to show it's item?

@m-mohr
Copy link
Collaborator Author

m-mohr commented Jan 28, 2025

is it intentional that item submenu now will open on the right of the ol-map

No. I'll check whether the old behaviour is possible with OpenLayers. Due to WebGL rendering, it might be difficult though.

Item preview in a collection view DO NOT use buildTileUrlTemplate to render it, but just direct COG read. In the screenshot on the left the collection view with inner items rendered directly without using buildTileUrlTemplate and on the right the item view that yes it uses the buildTileUrlTemplate. [...] In my case is a light problem because API follow a different authorization pattern. Is there a reason why collection view do not use TileLayer to show it's item?

I'm not sure I fully understand what you are saying.
As a general note: Tile servers have been disabled by default in STAC Browser as the client-side rendering is better than before. If needed, tile server rendering can be enforced in custom deployments through the options buildTileUrlTemplate (set to a function) and useTileLayerAsFallback (set to false).

@luipir
Copy link

luipir commented Jan 28, 2025

I'm not sure I fully understand what you are saying. As a general note: Tile servers have been disabled by default in STAC Browser as the client-side rendering is better than before. If needed, tile server rendering can be enforced in custom deployments through the options buildTileUrlTemplate (set to a function) and useTileLayerAsFallback (set to false).

not sure if it is a better rephrase of my question as been posted here where you already answered.

@m-mohr
Copy link
Collaborator Author

m-mohr commented Jan 28, 2025

is it intentional that item submenu now will open on the right of the ol-map

This has been fixed, it shows now where the mouse click happened. It can't directly attach to the feature anymore as we support selecting multiple features now. Beforehand you could only select the topmost is multiple features were stacked over each other.

Once the next ol-stac release is released, STAC Browser will also highlight the selected features in red again and have a bit of a hit tolerance to click smaller geometries easier.

Thanks for the report @luipir .

@luipir
Copy link

luipir commented Jan 28, 2025

This has been fixed, it shows now where the mouse click happened. It can't directly attach to the feature anymore as we support selecting multiple features now. Beforehand you could only select the topmost is multiple features were stacked over each other.

confirmed that it works now :)

Once the next ol-stac release is released, STAC Browser will also highlight the selected features in red again and have a bit of a hit tolerance to click smaller geometries easier.

:)

Thanks for the report @luipir .

thank you for the bug fix and new features :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
4 participants