Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support arrays for item filters #362

Open
rockliffelewis opened this issue Aug 29, 2023 · 1 comment · May be fixed by #339
Open

Support arrays for item filters #362

rockliffelewis opened this issue Aug 29, 2023 · 1 comment · May be fixed by #339
Labels
enhancement New feature or request funding needed

Comments

@rockliffelewis
Copy link

rockliffelewis commented Aug 29, 2023

As of 3.1.0-rc1 the supported data types for item filters are numerics, text, and booleans, which is applicable for the majority of cases, however one of the core fields of instrument is an array of strings (spec here)

It would be great to add support for this so that people can filter based on instrument types

@m-mohr
Copy link
Collaborator

m-mohr commented Aug 29, 2023

It might be that some implementations allow equal comparison for arrays, but "IN" would be better, indeed.
There's a draft PR for it, see #339. It's not ready to be merged and I'm lacking funding to further work on it, unfortunately.

@m-mohr m-mohr added the enhancement New feature or request label Aug 29, 2023
@m-mohr m-mohr linked a pull request Aug 29, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request funding needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants