From 0baf1176f70d189da53b81b30e07fb4419a9e4f1 Mon Sep 17 00:00:00 2001
From: Matthias Mohr <m.mohr@uni-muenster.de>
Date: Fri, 15 Mar 2024 01:49:11 +0100
Subject: [PATCH] No local variables #400 (#401)

---
 docker/docker-entrypoint.sh | 29 +++++++++++++++--------------
 1 file changed, 15 insertions(+), 14 deletions(-)

diff --git a/docker/docker-entrypoint.sh b/docker/docker-entrypoint.sh
index d38acc133..4cc2a3316 100755
--- a/docker/docker-entrypoint.sh
+++ b/docker/docker-entrypoint.sh
@@ -1,17 +1,18 @@
 # echo a string, handling different types
 safe_echo() {
-    local value="$1"
-    if [ -z "$value" ]; then
+    # $1 = value
+    if [ -z "$1" ]; then
         echo -n "null"
-    elif printf '%s\n' "$value" | grep -qE '\n.+\n$'; then
-        echo -n "\`$value\`"
+    elif printf '%s\n' "$1" | grep -qE '\n.+\n$'; then
+        echo -n "\`$1\`"
     else
-        echo -n "'$value'"
+        echo -n "'$1'"
     fi
 }
 
 #  handle boolean
 bool() {
+    # $1 = value
     case "$1" in
         true | TRUE | yes | t | True)
             echo -n true ;;
@@ -25,17 +26,17 @@ bool() {
 
 # handle array values
 array() {
-    local value="$1"
-    local arraytype="$2"
-    if [ -z "$value" ]; then
+    # $1 = value
+    # $2 = arraytype
+    if [ -z "$1" ]; then
         echo -n "[]"
     else
-        case "$arraytype" in
+        case "$2" in
             string)
-                echo -n "['$(echo "$value" | sed "s/,/', '/g")']"
+                echo -n "['$(echo "$1" | sed "s/,/', '/g")']"
                 ;;
             *)
-                echo -n "[$value]"
+                echo -n "[$1]"
                 ;;
         esac
     fi
@@ -43,11 +44,11 @@ array() {
 
 # handle object values
 object() {
-    local value="$1"
-    if [ -z "$value" ]; then
+    # $1 = value
+    if [ -z "$1" ]; then
         echo -n "null"
     else
-        echo -n "$value"
+        echo -n "$1"
     fi
 }