Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ArchiveFinder#all has too many arguments #2

Open
dkreft opened this issue Sep 30, 2010 · 0 comments
Open

ArchiveFinder#all has too many arguments #2

dkreft opened this issue Sep 30, 2010 · 0 comments

Comments

@dkreft
Copy link

dkreft commented Sep 30, 2010

In ArchiveFinder, we see this:

def all(method, options ={})
  self.find(:all, options)
end

But it makes no sense to call #all with two arguments, which is what this method suggests:

 # No
 my_stuff.all(:all, options)

I tried patching my local copy of this file to read thusly:

def all(options ={})
  self.find(:all, options)
end

But then it broke something else and I didn't feel like chasing it down.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant