Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Marginalia annotations disappear with prompt selection on find-file #561

Open
iyefrat opened this issue Jun 30, 2021 · 1 comment
Open

Comments

@iyefrat
Copy link

iyefrat commented Jun 30, 2021

Using find-file, moving the selection up to the prompt line will cause marginalia annotations to disappear if the path in the prompt is in a separate directory than one you first run the command in.

To reproduce, open emacs -Q and eval the following:

(require 'package)
(add-to-list 'package-archives '("melpa" . "https://melpa.org/packages/") t)
(package-initialize)
(package-refresh-contents)
(package-install 'marginalia)
(require 'marginalia)
(marginalia-mode)
(package-install 'selectrum)
(selectrum-mode +1)

Then, run find-file, navigate to a different directory in it, and move the selection up to the prompt line. When you have some partial path in the same directory you started in, moving the selection up to the prompt line doesn't cause the annotations to disappear, but this seems to happen for any other directory you move to. This is definitely an issue on the selectrum side since I can't reproduce this on vertico.

cc: @minad

@minad
Copy link
Contributor

minad commented Jun 30, 2021

I just checked this. This is indeed a Selectrum bug, selectrum--get-full seems to return a wrong value in that case.

@minad minad closed this as completed Jun 30, 2021
@minad minad reopened this Jun 30, 2021
@minad minad changed the title Marginalia annotations sometimes disappear on find-file Marginalia annotations disappear when prompt selection on find-file Jun 30, 2021
@minad minad changed the title Marginalia annotations disappear when prompt selection on find-file Marginalia annotations disappear with prompt selection on find-file Jun 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants