Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mouse face changes foreground on hover #508

Open
clemera opened this issue Mar 22, 2021 · 5 comments
Open

Mouse face changes foreground on hover #508

clemera opened this issue Mar 22, 2021 · 5 comments

Comments

@clemera
Copy link
Collaborator

clemera commented Mar 22, 2021

As reported by @haji-ali here:

But when I hover with the mouse, the foreground color changes depending on the foreground color of the character that the mouse was hovering before!

@haji-ali
Copy link
Contributor

Apologies, it turned out this is not a selectrum "issue".

Reading more about mouse-face, the face of a candidate is simply overridden when the mouse hovers over it including any segments that might have a different face. Hence why any forground colors are gone while a line is highlighted. The strange part is the fact that in my case the forground color of the highlighted candidate depends on the previously highlighted candidate; but this might be just be a bug in my setup.

@clemera
Copy link
Collaborator Author

clemera commented Mar 22, 2021

The strange part is the fact that in my case the forground color of the highlighted candidate depends on the previously highlighted candidate; but this might be just be a bug in my setup.

When I tried I had the same behavior. Might have something to do with using and overlay + the display property used by marginalia we had other display issues with this combination, too.

@apc
Copy link

apc commented Apr 19, 2021

From what I can tell, the issue has nothing to do with selectrum (as @haji-ali notes). Note that the same thing happens in an org-agenda view, e.g.: mouse-face simply overrides the foreground of the face on any item. See e.g.

image

vs.

image

(this is what happens when the mouse hovers over that item).

@bdarcus
Copy link
Contributor

bdarcus commented Apr 19, 2021

Maybe someone should report it as a bug to emacs?

@cyrus-and
Copy link

Before opening a new issue, I figured I could ask here. Since there's this inconsistency (bug or not), would it be possible to make selectrum-current-candidate behave in the same way, i.e., to override the existing foreground? IMHO it's a nice thing to have nevertheless.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

5 participants