Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Selectrum resizing issue with consult grouping #491

Closed
minad opened this issue Mar 11, 2021 · 7 comments
Closed

Selectrum resizing issue with consult grouping #491

minad opened this issue Mar 11, 2021 · 7 comments

Comments

@minad
Copy link
Contributor

minad commented Mar 11, 2021

See minad/consult#246. Maybe related to #270 and #435.
@minad minad mentioned this issue Mar 11, 2021
Closed
@haji-ali
Copy link
Contributor

Just to confirm that using (setq selectrum-group-format nil) did fix the issue (at the expense of the nice headers).

@clemera
Copy link
Collaborator

clemera commented Mar 11, 2021

The current resizing is done so you don't have dynamic resizing during operation but if the content height can change there is no way to avoid that. We can either allow dynamic resize during input or resize as soon as the selection moves into candidates which aren't currently displayed. Which do you think would be better?

@minad
Copy link
Contributor Author

minad commented Mar 11, 2021 •
edited
Loading

I think the current behavior is okay. It is unexpected if candidates are hidden/partially hidden, but usually you filter first and scroll afterwards. I almost never scroll but narrow down until I have less than 10 items.

@clemera
Copy link
Collaborator

clemera commented Mar 11, 2021 •
edited
Loading

For me it is the same and I think dynamic resize during input would be annoying. But for scrolling (or when the selected candidate is off screen) I think we could allow to grow if the contents don't fit.

@minad minad mentioned this issue Apr 7, 2021
Closed
@minad
Copy link
Contributor Author

minad commented Apr 13, 2021

See minad/vertico@b35592a and minad/vertico@24fab0b for a potential fix which works in Selectrum too.

This was referenced Apr 22, 2021
Closed
Closed
@iyefrat iyefrat mentioned this issue Jun 26, 2021
Merged
@manzaltu
Copy link

Is there any progress on this issue?
When working on large projects, you can’t always filter the results until you have less than x results that fit into the screen. Scrolling is an important feature of the minibuffer view.
I would love to use consult without disabling the grouping feature.

@iyefrat iyefrat mentioned this issue Jul 14, 2021
Merged
@minad minad mentioned this issue Jul 14, 2021
Closed
@dangirsh dangirsh mentioned this issue Jul 15, 2021
Closed
@Dima-369 Dima-369 mentioned this issue Nov 7, 2021
Closed
@manzaltu
Copy link

Sorry for spamming this issue. Didn't realize that Github will create a new reference to the issue every time I'm rebasing my commits 😅

manzaltu added a commit to manzaltu/modus-emacs that referenced this issue Aug 14, 2022
@manzaltu
Disable consult result grouping due to an issue in Selectrum
a95e984 
Selectrum sometimes hides results due to an issue with dynamic
resizing. This happens when viewing consult results and there are more
results than what the minibuffer can display in one screen. See here
radian-software/selectrum#491.

One possible solution is to get rid of Selectrum, and use Vertico
instead. However, Selectrum has some additional features that Vertico
lacks (e.g. caching, integration with Prescient).

The solution that was chosen is to disable consult result grouping
until the original Selectrum issue is resolved.
manzaltu added a commit to manzaltu/modus-emacs that referenced this issue Aug 20, 2022
@manzaltu
Disable consult result grouping due to an issue in Selectrum
3713bf5 
Selectrum sometimes hides results due to an issue with dynamic
resizing. This happens when viewing consult results and there are more
results than what the minibuffer can display in one screen. See here
radian-software/selectrum#491.

One possible solution is to get rid of Selectrum, and use Vertico
instead. However, Selectrum has some additional features that Vertico
lacks (e.g. caching, integration with Prescient).

The solution that was chosen is to disable consult result grouping
until the original Selectrum issue is resolved.
manzaltu added a commit to manzaltu/modus-emacs that referenced this issue Aug 22, 2022
@manzaltu
Disable consult result grouping due to an issue in Selectrum
fadb86c 
Selectrum sometimes hides results due to an issue with dynamic
resizing. This happens when viewing consult results and there are more
results than what the minibuffer can display in one screen. See here
radian-software/selectrum#491.

One possible solution is to get rid of Selectrum, and use Vertico
instead. However, Selectrum has some additional features that Vertico
lacks (e.g. caching, integration with Prescient).

The solution that was chosen is to disable consult result grouping
until the original Selectrum issue is resolved.
manzaltu added a commit to manzaltu/modus-emacs that referenced this issue Aug 27, 2022
@manzaltu
Disable consult result grouping due to an issue in Selectrum
fba7358 
Selectrum sometimes hides results due to an issue with dynamic
resizing. This happens when viewing consult results and there are more
results than what the minibuffer can display in one screen. See here
radian-software/selectrum#491.

One possible solution is to get rid of Selectrum, and use Vertico
instead. However, Selectrum has some additional features that Vertico
lacks (e.g. caching, integration with Prescient).

The solution that was chosen is to disable consult result grouping
until the original Selectrum issue is resolved.
@minad minad closed this as completed Jan 1, 2023
manzaltu added a commit to manzaltu/modus-emacs that referenced this issue May 4, 2023
@manzaltu
Disable consult result grouping due to an issue in Selectrum
4854d46 
Selectrum sometimes hides results due to an issue with dynamic
resizing. This happens when viewing consult results and there are more
results than what the minibuffer can display in one screen. See here
radian-software/selectrum#491.

One possible solution is to get rid of Selectrum, and use Vertico
instead. However, Selectrum has some additional features that Vertico
lacks (e.g. caching, integration with Prescient).

The solution that was chosen is to disable consult result grouping
until the original Selectrum issue is resolved.
manzaltu added a commit to manzaltu/modus-emacs that referenced this issue May 4, 2023
@manzaltu
Disable consult result grouping due to an issue in Selectrum
d7fac39 
Selectrum sometimes hides results due to an issue with dynamic
resizing. This happens when viewing consult results and there are more
results than what the minibuffer can display in one screen. See here
radian-software/selectrum#491.

One possible solution is to get rid of Selectrum, and use Vertico
instead. However, Selectrum has some additional features that Vertico
lacks (e.g. caching, integration with Prescient).

The solution that was chosen is to disable consult result grouping
until the original Selectrum issue is resolved.
manzaltu added a commit to manzaltu/modus-emacs that referenced this issue May 4, 2023
@manzaltu
Disable consult result grouping due to an issue in Selectrum
4973884 
Selectrum sometimes hides results due to an issue with dynamic
resizing. This happens when viewing consult results and there are more
results than what the minibuffer can display in one screen. See here
radian-software/selectrum#491.

One possible solution is to get rid of Selectrum, and use Vertico
instead. However, Selectrum has some additional features that Vertico
lacks (e.g. caching, integration with Prescient).

The solution that was chosen is to disable consult result grouping
until the original Selectrum issue is resolved.
manzaltu added a commit to manzaltu/modus-emacs that referenced this issue May 5, 2023
@manzaltu
Disable consult result grouping due to an issue in Selectrum
3064df5 
Selectrum sometimes hides results due to an issue with dynamic
resizing. This happens when viewing consult results and there are more
results than what the minibuffer can display in one screen. See here
radian-software/selectrum#491.

One possible solution is to get rid of Selectrum, and use Vertico
instead. However, Selectrum has some additional features that Vertico
lacks (e.g. caching, integration with Prescient).

The solution that was chosen is to disable consult result grouping
until the original Selectrum issue is resolved.
manzaltu added a commit to manzaltu/modus-emacs that referenced this issue May 5, 2023
@manzaltu
Disable consult result grouping due to an issue in Selectrum
13c575c 
Selectrum sometimes hides results due to an issue with dynamic
resizing. This happens when viewing consult results and there are more
results than what the minibuffer can display in one screen. See here
radian-software/selectrum#491.

One possible solution is to get rid of Selectrum, and use Vertico
instead. However, Selectrum has some additional features that Vertico
lacks (e.g. caching, integration with Prescient).

The solution that was chosen is to disable consult result grouping
until the original Selectrum issue is resolved.
manzaltu added a commit to manzaltu/modus-emacs that referenced this issue May 5, 2023
@manzaltu
Disable consult result grouping due to an issue in Selectrum
4804ca6 
Selectrum sometimes hides results due to an issue with dynamic
resizing. This happens when viewing consult results and there are more
results than what the minibuffer can display in one screen. See here
radian-software/selectrum#491.

One possible solution is to get rid of Selectrum, and use Vertico
instead. However, Selectrum has some additional features that Vertico
lacks (e.g. caching, integration with Prescient).

The solution that was chosen is to disable consult result grouping
until the original Selectrum issue is resolved.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@minad @manzaltu @clemera @haji-ali