Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Candidates are hidden when input is too long #484

Closed
mohkale opened this issue Mar 4, 2021 · 8 comments
Closed

Candidates are hidden when input is too long #484

mohkale opened this issue Mar 4, 2021 · 8 comments

Comments

@mohkale
Copy link
Contributor

mohkale commented Mar 4, 2021

The minibuffer window for selectrum seems to scroll once you input enough content which leads to the candidates on the current line being hidden. This would be fine cause you rarely input really long patterns but when your in a very long directory (eg. ~/.config/dotfiles/prog/editors/emacs/lisp/straight/repos/consult/) it makes certain commands such as find-file basically unusable.

You can see the scrolling affect in this asciicast.

Reproduction Instructions

  1. emacs -nw -q
  2. C-x b RET and input
(require 'selectrum)
(selectrum-mode +1)
  1. Try changing to a really deeply nested directory and notice how you can't see any of the files when running find-file.
@clemera
Copy link
Collaborator

clemera commented Mar 4, 2021

Thanks, this is another regression, fixed by a94fd9a?

@clemera
Copy link
Collaborator

clemera commented Mar 4, 2021

I just noticed that with highlight extension the highlighting can be off for that case the fix should be the same as mentioned in #450 propertizing the newline instead of the current space alignment.

@mohkale
Copy link
Contributor Author

mohkale commented Mar 4, 2021

@clemera

Now that I have your attention I'd just like to point out another maybe issue (hopefully without repeating the same reproduction instructions), selectrum--last-input doesn't seem to be updated ever, it's always set to "" for me. Is this another possible regression.

I use selectrum--last-input to update the regexp-search-ring for evil so I'd really like to get this fixed 😄.

@clemera
Copy link
Collaborator

clemera commented Mar 4, 2021

Can you provide more details? When doing any command, providing some input and then doing M-: + selectrum--last-input it shows the last minibuffer contents to me.

@mohkale
Copy link
Contributor Author

mohkale commented Mar 4, 2021

Oh sorry, I was mistaken. I triggered the debugger but didn't check the value of selectrum--last-input in the right buffer (did it in the debugger). That's on me, sorry.

@clemera
Copy link
Collaborator

clemera commented Mar 4, 2021

Nice :) Then I will close this one and the keep track of the highlighting issue in #450

@mohkale
Copy link
Contributor Author

mohkale commented Mar 31, 2021

@clemera

This isn't directly related to this issue but currently when the prompt is too long it still gets cut off even if the candidates are fine. For example when I'm in a really deep directory.

Screenshot_20210331_022940

I'm pretty sure it didn't used to be like this and personally I'd prefer the prompt to just flow over to the next line over getting cut off in the middle. Thoughts?

@clemera
Copy link
Collaborator

clemera commented Mar 31, 2021

I guess this is related to #426 ? We truncate lines by default so wrapping of the prompt isn't possible, the scrolling can be improved maybe that would improve the situation for you, too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants