Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mod_sp: unused code around scratch workspaces #319

Open
3 tasks
wilhelmy opened this issue Mar 3, 2021 · 5 comments
Open
3 tasks

mod_sp: unused code around scratch workspaces #319

wilhelmy opened this issue Mar 3, 2021 · 5 comments

Comments

@wilhelmy
Copy link
Collaborator

wilhelmy commented Mar 3, 2021

mod_sp handles the scratchpad and scratch workspaces. scratch workspaces are dead code.

  • Was there code in non-LGPL ion that did more with scratch workspaces?
  • should scratch workspaces do something?
  • if not, the dead code should be removed
@wilhelmy
Copy link
Collaborator Author

wilhelmy commented Mar 3, 2021

Does anyone here remember scratch workspaces and whether or not they ever did something useful?

@mjf
Copy link

mjf commented Jan 30, 2023

In general, to create "scratch workspace" with a pre-defined layout and hide and show it on demand (both actions configured to a simple keypress such as META+Mod1+Space to show and META+Mod1+Space again to hide it) would be splendid feature. I've also never used the scratch workspaces from the mod_sp but I extensively use regular scratchpad (META+Space) all the time and I can imagine some sort of "scratch workspaces" as I described would be pretty useful feature. It is achievable with Lua?

@wilhelmy
Copy link
Collaborator Author

wilhelmy commented Jan 31, 2023

I was talking about dead C code in mod_sp. I agree that scratchpads are great, but that isn't what this issue is about. For feature requests, please open a new issue.
Edit: or, more ideally, a pull request ;)

@mjf
Copy link

mjf commented Apr 20, 2023

scratch workspaces are dead code.

@wilhelmy I must have mistunderstood this issue. I thought it's about removing scratch workspaces completely. Therefor I tried to defend the idea and also ask if replacement in Lua exist, so... ?

@wilhelmy
Copy link
Collaborator Author

There's scratchpads and so-called scratch workspaces. The way I understand/remember it, scratch workspaces are a separate concept that's also handled by mod_sp but currently dead code. If no one remembers what they were supposed to do, I'd propose removing the dead code, or make it work by some other means.

Then again, dead code isn't really that much of a burden.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants