Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moving ~/.notion to ~/.config/notion. #310

Open
Scupake opened this issue Jan 16, 2021 · 12 comments
Open

Moving ~/.notion to ~/.config/notion. #310

Scupake opened this issue Jan 16, 2021 · 12 comments

Comments

@Scupake
Copy link

Scupake commented Jan 16, 2021

If that's currently possible, please show me how to do it, since I can't find anything about it.
If it's not, I would like you to consider following the XDG spec.

@raboof
Copy link
Owner

raboof commented Jan 16, 2021

Perhaps we should support both, to make it less painful for existing users?

Would you be interested in preparing a PR?

@raboof
Copy link
Owner

raboof commented Jan 16, 2021

Currently, I wonder if adding it to the search path with the -s parameter would work?

@Scupake
Copy link
Author

Scupake commented Jan 16, 2021

Perhaps we should support both, to make it less painful for existing users?

Maybe make it check if ~/.config/notion exists, if it does use that, if it doesn't it uses ~/.notion.

Would you be interested in preparing a PR?

uhhh, what do you mean exactly? Adding the code? or just an empty WIP PR?

@raboof
Copy link
Owner

raboof commented Jan 16, 2021

Perhaps we should support both, to make it less painful for existing users?

Maybe make it check if ~/.config/notion exists, if it does use that, if it doesn't it uses ~/.notion.

That makes sense to me. Looking for all resources in both locations might also be fine.

Would you be interested in preparing a PR?

uhhh, what do you mean exactly? Adding the code? or just an empty WIP PR?

Adding the code ;)

@Scupake
Copy link
Author

Scupake commented Jan 16, 2021

Oh, well I'm not very good at C, but I'll try to.

@md1023
Copy link

md1023 commented Jan 16, 2021

Symbolic links work well on my Linux installations:

23:40:43 pwd
/home/mnikolaev
23:40:52 ls -al .notion
lrwxrwxrwx 1 mnikolaev mnikolaev 50 янв 15 20:04 .notion -> /home/mnikolaev/Documents/olivetti/configs/.notion/

Is that desirable or you want to get rid of ~/.notion completely?

@Scupake
Copy link
Author

Scupake commented Jan 17, 2021

I want to get rid of it completely, home dir clutter annoys me a lot

@wilhelmy
Copy link
Collaborator

  • notionflux needs to be handled separately, ~/.notion/notionflux.hist is currently hardcoded

Other than that, I'm fine with supporting both locations.

@wilhelmy
Copy link
Collaborator

wilhelmy commented Jan 20, 2021

I think to formally support ~/.config properly, also the XDG_CONFIG_HOME variable needs to be handled. Also the history shouldn't go into ~/.config/notion but ~/.local/share/notion or something like that. Haven't read the full spec: https://specifications.freedesktop.org/basedir-spec/basedir-spec-latest.html

Edit: might be a good way to learn a little C, this seems like a simple task.

@Scupake
Copy link
Author

Scupake commented Jan 21, 2021

Yeah, it's good idea. But just supporting ~/.config is enough for me.
I'll try to add support for the XDG spec , gonna take a while though since I'm really bad at programming in general and have never used C before.

EDIT: Maybe rename the issue to "XDG specification support."?

@raboof
Copy link
Owner

raboof commented Jan 21, 2021

But just supporting ~/.config is enough for me.

I think first 'simply' adding support for ~/.config and leaving more sophisticated support for future PR's would be fine.

gonna take a while though since I'm really bad at programming in general and have never used C before.

If you run into any roadblocks feel free to ask! I think it's great that you're even considering this at all!

Maybe rename the issue to "XDG specification support."?

All of XDG is very broad, I think it's fine to have separate issues about various parts.

@wilhelmy
Copy link
Collaborator

wilhelmy commented Feb 23, 2021

@Scupake if you need any help, I think I have enough time on my hands again to give some IRC support/mentoring. Speaking from personal experience, messing with things you're kind of clueless about is a fun way to learn stuff, if that's what you're after.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants