Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make DOCKERHOST_IP and DOCKERHOST_HOSTNAME a configuration option #173

Open
craffit opened this issue Jan 31, 2017 · 1 comment
Open

Make DOCKERHOST_IP and DOCKERHOST_HOSTNAME a configuration option #173

craffit opened this issue Jan 31, 2017 · 1 comment

Comments

@craffit
Copy link
Collaborator

craffit commented Jan 31, 2017

Currently DOCKERHOST_IP and DOCKERHOST_NAME are not configuration options. This not work well when turning connectionbeat into a linux service, because linux services have their environment cleared. The configuration file would be a more logical place for these settings.

@raboof
Copy link
Owner

raboof commented Feb 13, 2017

Passing those in through environment variables does make sense when connbeat is started in a docker container (12-factor and all that), but indeed when started from systemd it'd make sense to allow configuration from the configuration file. Let's see if we can support both.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants