Skip to content

Commit c2bfcc4

Browse files
committed
Remove debug log statements in stream SAC coordinator
They can be useful and are not on hot paths, but they are replicated on all nodes as part of the state machine replication, so we are better off removing them to avoid noise. References #7743
1 parent 059ea6b commit c2bfcc4

File tree

1 file changed

+1
-26
lines changed

1 file changed

+1
-26
lines changed

deps/rabbit/src/rabbit_stream_sac_coordinator.erl

+1-26
Original file line numberDiff line numberDiff line change
@@ -247,8 +247,6 @@ apply(#command_activate_consumer{vhost = VirtualHost,
247247
stream = Stream,
248248
consumer_name = ConsumerName},
249249
#?MODULE{groups = StreamGroups0} = State0) ->
250-
rabbit_log:debug("Activating consumer on ~tp, group ~p",
251-
[Stream, ConsumerName]),
252250
{G, Eff} =
253251
case lookup_group(VirtualHost, Stream, ConsumerName, StreamGroups0) of
254252
undefined ->
@@ -259,11 +257,7 @@ apply(#command_activate_consumer{vhost = VirtualHost,
259257
Group ->
260258
#consumer{pid = Pid, subscription_id = SubId} =
261259
evaluate_active_consumer(Group),
262-
rabbit_log:debug("New active consumer on ~tp, group ~tp " ++
263-
"is ~tp from ~tp",
264-
[Stream, ConsumerName, SubId, Pid]),
265-
Group1 =
266-
update_consumer_state_in_group(Group, Pid, SubId, true),
260+
Group1 = update_consumer_state_in_group(Group, Pid, SubId, true),
267261
{Group1, [notify_consumer_effect(Pid, SubId, Stream, ConsumerName, true)]}
268262
end,
269263
StreamGroups1 =
@@ -553,10 +547,6 @@ do_register_consumer(VirtualHost,
553547
%% the current active stays the same
554548
{G1, []};
555549
_ ->
556-
rabbit_log:debug("SAC consumer registration: " ++
557-
"active consumer change on stream ~tp, group ~tp. " ++
558-
"Notifying ~tp from ~tp it is no longer active.",
559-
[Stream, ConsumerName, ActSubId, ActPid]),
560550
%% there's a change, telling the active it's not longer active
561551
{update_consumer_state_in_group(G1,
562552
ActPid,
@@ -570,9 +560,6 @@ do_register_consumer(VirtualHost,
570560
true)]}
571561
end;
572562
false ->
573-
rabbit_log:debug("SAC consumer registration: no active consumer on stream ~tp, group ~tp. " ++
574-
"Likely waiting for a response from former active consumer.",
575-
[Stream, ConsumerName]),
576563
%% no active consumer in the (non-empty) group,
577564
%% we are waiting for the reply of a former active
578565
{G1, []}
@@ -618,11 +605,6 @@ handle_consumer_removal(Group0, Consumer, Stream, ConsumerName) ->
618605
%% the current active stays the same
619606
{Group0, []};
620607
_ ->
621-
rabbit_log:debug("SAC consumer removal: " ++
622-
"active consumer change on stream ~tp, group ~tp. " ++
623-
"Notifying ~tp from ~tp it is no longer active.",
624-
[Stream, ConsumerName, ActSubId, ActPid]),
625-
626608
%% there's a change, telling the active it's not longer active
627609
{update_consumer_state_in_group(Group0,
628610
ActPid,
@@ -637,17 +619,10 @@ handle_consumer_removal(Group0, Consumer, Stream, ConsumerName) ->
637619
%% the active one is going away, picking a new one
638620
#consumer{pid = P, subscription_id = SID} =
639621
evaluate_active_consumer(Group0),
640-
rabbit_log:debug("SAC consumer removal: " ++
641-
"active consumer change on stream ~tp, group ~tp. " ++
642-
"Notifying ~tp from ~tp it is the new active consumer.",
643-
[Stream, ConsumerName, SID, P]),
644622
{update_consumer_state_in_group(Group0, P, SID, true),
645623
[notify_consumer_effect(P, SID,
646624
Stream, ConsumerName, true)]};
647625
false ->
648-
rabbit_log:debug("SAC consumer removal: no active consumer on stream ~tp, group ~tp. " ++
649-
"Likely waiting for a response from former active consumer.",
650-
[Stream, ConsumerName]),
651626
%% no active consumer in the (non-empty) group,
652627
%% we are waiting for the reply of a former active
653628
{Group0, []}

0 commit comments

Comments
 (0)