Skip to content

Commit 741e04b

Browse files
committed
Rename "build-dist" target to "source-bundle"
This incorporates PR feedback from @michaelklishin Signed-off-by: Kartik Ganesh <[email protected]>
1 parent aa9e0a5 commit 741e04b

File tree

1 file changed

+6
-6
lines changed

1 file changed

+6
-6
lines changed

Makefile

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -138,7 +138,7 @@ endef
138138
# --------------------------------------------------------------------
139139

140140
.PHONY: source-dist clean-source-dist
141-
.PHONY: build-dist clean-build-dist
141+
.PHONY: source-bundle clean-source-bundle
142142

143143
SOURCE_DIST_BASE ?= rabbitmq-server
144144
SOURCE_DIST_SUFFIXES ?= tar.xz
@@ -151,8 +151,8 @@ SOURCE_DIST_FILES = $(addprefix $(SOURCE_DIST).,$(SOURCE_DIST_SUFFIXES))
151151
.PHONY: $(SOURCE_DIST_FILES)
152152

153153
# Override rsync flags as a pre-requisite
154-
build-dist: RSYNC_FLAGS = $(BUILD_DIST_RSYNC_FLAGS)
155-
build-dist: $(SOURCE_DIST_FILES)
154+
source-bundle: RSYNC_FLAGS = $(SOURCE_BUNDLE_RSYNC_FLAGS)
155+
source-bundle: $(SOURCE_DIST_FILES)
156156
@:
157157

158158
# Override rsync flags as a pre-requisite
@@ -222,10 +222,10 @@ SOURCE_DIST_RSYNC_FLAGS += $(BASE_RSYNC_FLAGS) \
222222
--exclude 'packaging' \
223223
--exclude 'test'
224224

225-
# For build-dist, explicitly include folders that are needed
225+
# For source-bundle, explicitly include folders that are needed
226226
# for tests to execute. These are added before excludes from
227227
# the base flags so rsync honors the first match.
228-
BUILD_DIST_RSYNC_FLAGS += \
228+
SOURCE_BUNDLE_RSYNC_FLAGS += \
229229
--include 'rabbit_shovel_test/ebin' \
230230
--include 'rabbit_shovel_test/ebin/*' \
231231
--include 'rabbitmq_ct_helpers/tools' \
@@ -395,7 +395,7 @@ $(SOURCE_DIST).zip: $(SOURCE_DIST).manifest
395395

396396
clean:: clean-source-dist
397397

398-
clean-build-dist:: clean-source-dist
398+
clean-source-bundle:: clean-source-dist
399399

400400
clean-source-dist:
401401
$(gen_verbose) rm -rf -- $(SOURCE_DIST_BASE)-*

0 commit comments

Comments
 (0)