Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

search_finna #2

Open
antagomir opened this issue Nov 3, 2024 · 1 comment
Open

search_finna #2

antagomir opened this issue Nov 3, 2024 · 1 comment

Comments

@antagomir
Copy link
Member

antagomir commented Nov 3, 2024

I ran the following:

library(finna)
fennica <- search_finna("*",filters=c('collection:"FEN"'))
print(fennica)

To my surprise, fennica object had just 100 rows (I expected tens of thousands).

Little investigation shows that the function has default limit 100.

This is not immediately obvious. It would be good to throw a warning if the default is used.

Examples could include the limit argument so it is more clear, or mention in the explanations immediately (before running the example) that it will only return the top-100.

@antagomir
Copy link
Member Author

It is possible to programmatically check the size of each collection?

ake123 added a commit that referenced this issue Nov 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant