Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typehinting is not accounted for #6

Open
JimmyBanks opened this issue Aug 12, 2021 · 2 comments
Open

Typehinting is not accounted for #6

JimmyBanks opened this issue Aug 12, 2021 · 2 comments
Assignees
Labels
bug Something isn't working

Comments

@JimmyBanks
Copy link

When a property has a type hint the return value should equally display that type hint.

For example, property is type hinted as an integer. The getter should realize that this value must be an integer and also type hint the return as an integer.

Screen Shot 2021-08-11 at 11 08 32 PM

@r4ven1245
Copy link
Owner

r4ven1245 commented Oct 25, 2021

I completely forgot about property declaration in __construct.
Might as well update the line reader, to avoid future issues
Will fix

@r4ven1245 r4ven1245 self-assigned this Oct 25, 2021
@r4ven1245 r4ven1245 added the bug Something isn't working label Oct 25, 2021
@DavidAbderhalden
Copy link

From the conversation I can't really tell if this issue has been resolved already. For me the type hints are being generated as they should, except for union types:

image

Type hints are being considered
image

Union type hints are not being considered
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants