Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Question: Re-add custom templating option? #1

Open
leonp5 opened this issue Apr 3, 2021 · 6 comments
Open

Question: Re-add custom templating option? #1

leonp5 opened this issue Apr 3, 2021 · 6 comments
Assignees
Labels
enhancement New feature or request

Comments

@leonp5
Copy link

leonp5 commented Apr 3, 2021

Hi,
thanks for developing this extension :)
As mentioned in the title, i wonder, why did you remove the custom template functionality?
I think it's a useful feature and would appreciate if it is possible to implement it again or in a similar way.
Regards,
Leon

@leonp5 leonp5 changed the title Question: Readd custom templating option? Question: Re-add custom templating option? Apr 3, 2021
@r4ven1245
Copy link
Owner

r4ven1245 commented Apr 3, 2021

Hi Leon,

The legacy template functionality interferes with the Short Template option, and now with the Static property support the template looks a bit messy.
Of course, both of them aren't really problems, they just add some complications to the templates. For which I didn't really have the time to implement when I released the extension. But now I do have time.

I could restore the legacy templates and modify the Property class to hold the value of phpGetterSetter.short, so that you can use it in templating. The class already holds the isStatic flag, so it's already available.

@leonp5
Copy link
Author

leonp5 commented Apr 3, 2021

@r4ven1245 thanks for your quick answer.

The class already holds the isStatic flag, so it's already available.

Does that mean the options from @phproberto extension (seen on the screenshot) are already available?

grafik

@r4ven1245
Copy link
Owner

r4ven1245 commented Apr 3, 2021 via email

@r4ven1245
Copy link
Owner

Will re-add the functionality as described above

@r4ven1245 r4ven1245 self-assigned this Oct 25, 2021
@r4ven1245 r4ven1245 added the enhancement New feature or request label Oct 25, 2021
@hrvoj3e
Copy link

hrvoj3e commented Nov 24, 2021

I am using templates only to remove doc block.
Could you maybe add a config option for show/hide dock blocks?

Type hinting works OK. Thanks for that. This was missing in phproberto version.

@r4ven1245
Copy link
Owner

I am using templates only to remove doc block. Could you maybe add a config option for show/hide dock blocks?

Type hinting works OK. Thanks for that. This was missing in phproberto version.

I'll try adding as much customization as possible, I'll add it too

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants