Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

running lein test crashes phantomjs #92

Open
dqdinh opened this issue Mar 10, 2016 · 4 comments
Open

running lein test crashes phantomjs #92

dqdinh opened this issue Mar 10, 2016 · 4 comments

Comments

@dqdinh
Copy link

dqdinh commented Mar 10, 2016

Hi, I'm trying to run the unit tests but phantomjs crashes before completing. Strangely the tests pass on travis (https://travis-ci.org/r0man/cljs-http)

Do these tests pass on your local system? Any ideas why this is happening?

➜  cljs-http git:(master) ✗ lein version
Leiningen 2.6.1 on Java 1.8.0_45 Java HotSpot(TM) 64-Bit Server VM

➜  cljs-http git:(master) lein test

;; ======================================================================
;; Testing with Phantom:


Testing cljs-http.client-test

FAIL in (test-cancel-channel) (:)
expected: (= resp nil)
  actual: (not (= {:status -1, :success false, :body "", :headers {}, :trace-redirects ["http://google.com" "http://google.com"], :error-code :exception, :error-text "Error: NETWORK_ERR: XMLHttpRequest Exception 101"} nil))

FAIL in (http-error-code) (:)
expected: (= :no-error (:error-code (<! success-req)))
  actual: (not (= :no-error :exception))

FAIL in (http-error-code) (:)
expected: (= :timeout (:error-code (<! timeout-req)))
  actual: (not (= :timeout :exception))
TypeError: Type error

  phantomjs://code/phantom5315752302497335760.js:74 in onError
Subprocess failed
@r0man
Copy link
Owner

r0man commented Mar 11, 2016

@dqdinh The tests used to pass. They fail on my local machine as well now. I'm running phantomjs 2.1.1. I think the tests assert on some phantomjs internals that have changed now. I think this needs to be changed.

@r0man
Copy link
Owner

r0man commented Mar 11, 2016

I just updated the dependencies and run the tests on Travis. They passed, so this is related to some changes on phantomjs. I don't have time to work on this at the moment. Patch that works on all phantomjs versions welcome ... ;)

@dqdinh
Copy link
Author

dqdinh commented Mar 16, 2016

@r0man - I'll look into this and see if I can get the tests to pass.

@a1exsh
Copy link
Contributor

a1exsh commented Mar 28, 2018

Still an issue here with phantomjs-2.1.1+dfsg-2 on Ubuntu 17.10. :(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants