chore: resolve review comments

Author: chungquantin

Cargo.lock

@@ -6,7 +6,7 @@ name = "pop-api"
 version = "0.0.0"
 
 [dependencies]
-bitflags = { version = "1.3.2", optional = true }
+bitflags = { version = "2.8.0", optional = true }
 enumflags2 = { version = "0.7.9", optional = true }
 
 # Pop.

pop-api/Cargo.lock

@@ -312,7 +312,7 @@ pub(super) mod nfts {
 			collection,
 			item,
 			operator.clone().into(),
-			Some(BlockNumber::MAX)
+			Some(u32::MAX)
 		));
 		(collection, item)
 	}
@@ -352,9 +352,9 @@ pub(super) mod nfts {
 	pub(crate) fn default_mint_settings() -> MintSettings {
 		MintSettings {
 			mint_type: MintType::Issuer,
-			price: Some(Balance::MAX),
-			start_block: Some(BlockNumber::MIN),
-			end_block: Some(BlockNumber::MAX),
+			price: Some(u128::MAX),
+			start_block: Some(u32::MIN),
+			end_block: Some(u32::MAX),
 			default_item_settings: ItemSettings::all_enabled(),
 		}
 	}

pop-api/Cargo.toml

@@ -198,10 +198,10 @@ mod tests {
 	#[test]
 	fn ensure_mint_witness() {
 		assert_eq!(
-			MintWitness { owned_item: Some(ItemId::MAX), mint_price: Some(Balance::MAX) }.encode(),
+			MintWitness { owned_item: Some(u32::MAX), mint_price: Some(u128::MAX) }.encode(),
 			pallet_nfts::MintWitness::<ItemId, Balance> {
-				owned_item: Some(ItemId::MAX),
-				mint_price: Some(Balance::MAX)
+				owned_item: Some(u32::MAX),
+				mint_price: Some(u128::MAX)
 			}
 			.encode()
 		);
@@ -258,12 +258,11 @@ mod tests {
 	#[test]
 	fn ensure_mint_type() {
 		assert_eq!(
-			vec![MintType::Issuer, MintType::Public, MintType::HolderOf(CollectionId::MAX)]
-				.encode(),
+			vec![MintType::Issuer, MintType::Public, MintType::HolderOf(u32::MAX)].encode(),
 			vec![
 				pallet_nfts::MintType::Issuer,
 				pallet_nfts::MintType::Public,
-				pallet_nfts::MintType::HolderOf(CollectionId::MAX)
+				pallet_nfts::MintType::HolderOf(u32::MAX)
 			]
 			.encode()
 		);
@@ -330,9 +329,9 @@ mod tests {
 	fn default_mint_settings() -> MintSettings {
 		MintSettings {
 			mint_type: MintType::Public,
-			price: Some(Balance::MAX),
-			start_block: Some(BlockNumber::MIN),
-			end_block: Some(BlockNumber::MAX),
+			price: Some(u128::MAX),
+			start_block: Some(u32::MIN),
+			end_block: Some(u32::MAX),
 			default_item_settings: ItemSettings::all_enabled(),
 		}
 	}
@@ -341,9 +340,9 @@ mod tests {
 	) -> pallet_nfts::MintSettings<Balance, BlockNumber, CollectionId> {
 		pallet_nfts::MintSettings::<Balance, BlockNumber, CollectionId> {
 			mint_type: pallet_nfts::MintType::Public,
-			price: Some(Balance::MAX),
-			start_block: Some(BlockNumber::MIN),
-			end_block: Some(BlockNumber::MAX),
+			price: Some(u128::MAX),
+			start_block: Some(u32::MIN),
+			end_block: Some(u32::MAX),
 			default_item_settings: pallet_nfts::ItemSettings::all_enabled(),
 		}
 	}