Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gcc13 issue #223

Closed
edzer opened this issue Mar 29, 2023 · 8 comments · Fixed by #228
Closed

gcc13 issue #223

edzer opened this issue Mar 29, 2023 · 8 comments · Fixed by #228

Comments

@edzer
Copy link
Member

edzer commented Mar 29, 2023

From CRAN:

Dear maintainer,

Please see the problems shown on
[<https://cran.r-project.org/web/checks/check_results_s2.html>](https://cran.r-project.org/web/checks/check_results_s2.html).

Please correct before 2023-04-12 to safely retain your package on CRAN.

Do remember to look at the 'Additional issues'.

The CRAN Team
@paleolimbot
Copy link
Collaborator

Bit of a trick to find the actual error but maybe:

../src/absl/strings/cord.h:1182:9: warning: writing 16 bytes into a region of size 3 [-Wstringop-overflow=]
 1182 |   memcpy(result->Data(), data_.as_chars(), sizeof(data_));
      |         ^
In file included from ../src/absl/strings/cord_analysis.h:22,
                 from ../src/absl/strings/cord.h:82:
../src/absl/strings/internal/cord_internal.h:242:11: note: destination object 'absl::lts_20220623::cord_internal::CordRep::storage' of size 3
  242 |   uint8_t storage[3];
      |           ^~~~~~~
../src/absl/strings/cord.h: In member function 'void absl::lts_20220623::Cord::InlineRep::PrependTreeToInlined(absl::lts_20220623::Cord::CordRep*, absl::lts_20220623::Cord::MethodIdentifier)':
../src/absl/strings/cord.h:1182:9: warning: writing 16 bytes into a region of size 3 [-Wstringop-overflow=]
 1182 |   memcpy(result->Data(), data_.as_chars(), sizeof(data_));
      |         ^
../src/absl/strings/internal/cord_internal.h:242:11: note: destination object 'absl::lts_20220623::cord_internal::CordRep::storage' of size 3
  242 |   uint8_t storage[3];
      |           ^~~~~~~

@edzer
Copy link
Member Author

edzer commented Apr 12, 2023

We have a final reminder until 2023-04-26. Did you have a chance to look into this one?

@edzer
Copy link
Member Author

edzer commented Apr 12, 2023

The check results now summarize the problem to

* checking whether package ‘s2’ can be installed ... [21m/15m] WARNING
Found the following significant warnings:
  ../src/absl/strings/cord.h:1182:9: warning: writing 16 bytes into a region of size 3 [-Wstringop-overflow=]
See ‘/data/gannet/ripley/R/packages/tests-gcc13/s2.Rcheck/00install.out’ for details.

@edzer
Copy link
Member Author

edzer commented Apr 12, 2023

It seems upstream no longer uses memcpy here:
https://github.com/abseil/abseil-cpp/blob/master/absl/strings/cord.h#L1148
so maybe update absl?

@paleolimbot
Copy link
Collaborator

Sorry, I forgot. I will take a look today (latest: tomorrow).

Updating abseil is a pain so if possible I'd like to patch. I believe that S2 only uses the Abseil strings module for logging and import/export of the text format that it invented (neither of which we use), so it's not a critical piece as far as I know.

@edzer
Copy link
Member Author

edzer commented Apr 17, 2023

Did you get around looking into this one?

@paleolimbot
Copy link
Collaborator

Both kids have RSV 😬 (but 4/26 shouldn't be a problem!)

@paleolimbot paleolimbot mentioned this issue Apr 18, 2023
Merged
@paleolimbot
Copy link
Collaborator

(both kids currently asleep 👍 )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Patch cord.h to remove CRAN warning r-spatial/s2
2 participants
@edzer @paleolimbot