Improve addin #122
Open
Improve addin #122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this is an updated version of the addin from open pr #85. The original pr included code that assigned the output of the addin to the global environment. This work have caused issues with cran submissions.
In this update the output can be saved to file as before, but is also returned to the console so the output can later be assigned using
.Last.value. Alternatively the function can be run directly viacreateFeatures()Finally I have added the recent
editAttributesfunction as an additional rstudio addin. Essentially this allows minimal basic usage of the app using the GUI alone. The addin simply runseditAttributes(), again the user would have to use.Last.valueto assign the output. For this to work the fix enablingeditAttributes()in PR #121 needs to be merged first.Please there is no rush to look at these PR's. The work on
editAttributesreminded me of this addin and gave me some ideas to fix it.thanks
Matt