-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Provide conversions as CSVs #2
Comments
In case this is useful, I have implemented conversions between mols of chemical elements and grams of chemical elements in the 'elco' package. I could reformat this table so that it could be used in the planned package. |
I think that a mass/molar conversion for chemical elements would be helpful. I also think it would be helpful to have multiple examples (elements and clinical laboratory measurements) at the beginning so that we can think if there are difference between different domains. It'll take me a couple of days to pull together some clinical unit conversions-- I almost always do them as one-off conversions, so I don't have a .csv available. |
@henningte That would be great, thanks. @billdenney Sure, no hurries, thanks. |
@Enchufa2, @DBartlettHP has made a PR that will help the discussion of clinical lab unit conversion. I realized that the discussion of how to handle the details would probably be better here than in the PR, so I'm going to reiterate and expand on what I said there in this issue:
So, the way that I think it would make sense to register a new substance is something like:
How does that sound? |
We could make separate packages (e.g.
substances.clinical
,substances.chem
...) for specific domains, but those packages would only provide a dataframe of conversions, so I don't think it makes much sense. I would centralize everything here, and provide them as CSVs. (I'm supposing here that there's no authoritative source from where we can query or scrape this info, and basically that we need to compile these by hand).@billdenney: If there's no better way, could you please provide your current databases for these conversions (including the standard units) as
inst/extdata/clinical.csv
, etc., in a PR? If you think this would be better managed externally, we would still need some sample data in this package for development and testing.The text was updated successfully, but these errors were encountered: