Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some page sections are no longer translated #2832

Open
jmaspons opened this issue Dec 17, 2024 · 5 comments
Open

Some page sections are no longer translated #2832

jmaspons opened this issue Dec 17, 2024 · 5 comments

Comments

@jmaspons
Copy link
Contributor

For example, https://osm-catalan.github.io/monitorOSM/docs/ should be translated in Catalan as per https://github.com/OSM-Catalan/monitorOSM/blob/af9ec15532fab3a0c23afb56022e9c7e1dc021d8/_pkgdown.yml#L4. It used to work, but not with pkgdown 2.1.1. I don't know when it starts failing.

@jayhesselberth
Copy link
Collaborator

jayhesselberth commented Dec 17, 2024

The site you linked to appears to be in Catalan (at least my browser prompts me to convert Catalan to English when I visit), and it's built with 2.1.1 (version number at the bottom of the page). Not sure what you're seeing?

@jmaspons
Copy link
Contributor Author

imatge
That's what I see. The red squares should be in Catalan. My browser is configured in Catalan

@jayhesselberth jayhesselberth changed the title lang parameter not working anymore Some page sections are no longer translated Dec 18, 2024
@jayhesselberth
Copy link
Collaborator

I added lang: es to pkgdown and rebuilt the home page. Everything except the main section is translated (the opposite of what you're seeing). Weird.

image

@hadley
Copy link
Member

hadley commented Dec 18, 2024

@jayhesselberth that's because the README is already in Catalan: https://github.com/OSM-Catalan/monitorOSM/?tab=readme-ov-file#monitorosm-

Do you get a translated navbar if you build OSM-Catalan docs locally?

@jmaspons
Copy link
Contributor Author

jmaspons commented Dec 18, 2024

Do you get a translated navbar if you build OSM-Catalan docs locally?

Yes, it works locally! So some problem with github actions I guess. Feel free to close the issue if you think there is nothing wrong here. I have not changed https://github.com/OSM-Catalan/monitorOSM/blob/main/.github/workflows/pkgdown.yaml but somehow it broke.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants