-
Notifications
You must be signed in to change notification settings - Fork 337
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Quarto vignettes use the installed version of the package, but Rmd vignettes use the current dev version #2830
Comments
Hmmm, probably need to set |
This may be related or the same: quarto-dev/quarto-actions#120 |
Update: @cderv confirmed that the above issue is the same as this. It is a bug that hinders use of .qmd files for vignettes and, unlike @venpopov's statement above, we found it can lead to error messages in Actions. I would say this is fairly high priority, anything I can do to help with diagnostics/fix testing let me know 🙏 |
I agree with this. @jayhesselberth I can help with that. I'll try to do a PR to fix this. |
@cderv If is something that will come up frequently maybe this could also be adressed in the quarto R package with a |
I am not sure it will be often, but surely in some context like pkgdown when
pkgdown being the one to install in a temp directory, it would make sense for it to be sure this libs is known to the new process. Thouhg, I wonder if this can create some issue with vignette engine too, so I'll check. |
I just found out you can have Quarto vignettes and to try them out, I created a new package. I added a quarto vignette, but when I tried to build the site with
build_site()
, I got the following error:Rendering regular .Rmd vignettes was fine. I was finally able to track down the issue: the code
library(mytestpkg)
in the vignette failed for the Quarto vignette, because in contrast to the Rmd vignette, it did not use see the temporary library.Ok, so I
install()
the package locally and then it renders successfully. The problem is that if you make any updates, and you rebuild the website, the Quarto vignette will be built with the locally installed version, while the Rmd vignettes will be built with the current version thatbuild_site()
installs to a temporary library.The deployment via github pages workflow doesn't have this problem and everything works fine, but locally Rmd and Qmd vignettes are built differently.
The text was updated successfully, but these errors were encountered: