Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sysreqs is not resolved correctly from a package published about 3 days ago #692

Closed
zhuxr11 opened this issue Sep 21, 2024 · 4 comments
Closed

Comments

@zhuxr11
Copy link

zhuxr11 commented Sep 21, 2024

A package hypergeo2 was published on CRAN about 3 days ago. Just now I started a github R CMD CHECK workflow using pak to set up dependencies including hypergeo2 for another package cbbinom, and the system requirements of hypergeo2 was not discovered correctly, failing to install hypergeo2 in the workflow.

Here was what I ran just now:

pak::meta_update()
#> v Updating metadata database ... done                             

pak::pkg_system_requirements("hypergeo2", "ubuntu", "20.04")
#> [1] "apt-get install -y libgmp3-dev" "apt-get install -y libmpfr-dev"

pak::pkg_deps("hypergeo2")[c("ref", "package", "repotype", "sysreqs")]
#> # A data frame: 3 x 4
#>   ref       package   repotype sysreqs
#>   <chr>     <chr>     <chr>    <chr>  
#> 1 BH        BH        cran     ""     
#> 2 hypergeo2 hypergeo2 cran     NA     
#> 3 Rcpp      Rcpp      cran     ""     

We see: pak::pky_system_requirements() found the system requirements correctly (gmp and mpfr), but pak::pkg_deps() (used to set up dependencies in the workflow) printed the sysreqs as NA. This happened after running pak::meta_update(), thus with the newest metadata database.

@gaborcsardi
Copy link
Member

This should be fixed now:

❯ options(pkg.platforms = "source")
❯ pak::pkg_deps("hypergeo2")[c("ref", "package", "repotype", "sysreqs")]
# A data frame: 3 × 4
  ref       package   repotype sysreqs    
  <chr>     <chr>     <chr>    <chr>      
1 BH        BH        cran     ""         
2 hypergeo2 hypergeo2 cran     "gmp, mpfr"
3 Rcpp      Rcpp      cran     ""         

@zhuxr11
Copy link
Author

zhuxr11 commented Sep 25, 2024

This should be fixed now:

❯ options(pkg.platforms = "source")
❯ pak::pkg_deps("hypergeo2")[c("ref", "package", "repotype", "sysreqs")]
# A data frame: 3 × 4
  ref       package   repotype sysreqs    
  <chr>     <chr>     <chr>    <chr>      
1 BH        BH        cran     ""         
2 hypergeo2 hypergeo2 cran     "gmp, mpfr"
3 Rcpp      Rcpp      cran     ""         

Great, when will this update be applied to the "check-standard" github workflow? Or how can I set that in R-CMD-CHECK.yaml?

@gaborcsardi
Copy link
Member

It should already work on GHA as well, no need to set anything.

@zhuxr11
Copy link
Author

zhuxr11 commented Sep 26, 2024

It should already work on GHA as well, no need to set anything.

Thanks, the workflow is running smoothly now.

@zhuxr11 zhuxr11 closed this as completed Sep 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants