-
Notifications
You must be signed in to change notification settings - Fork 187
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Should lint_package()
error on CI?
#1226
Comments
Maybe a custom function would be better — then you could generate markdown for https://github.blog/2022-05-09-supercharging-github-actions-with-job-summaries/ that provided clickable links that took you directly to the problem. |
Markdown report could just be third option in |
We currently produce check annotations, and support error_on_lint to exit if a lint is found. |
@hadley PTAL at this repo's current GHA set-up. We recently updated lintr/.github/workflows/lint-changed-files.yaml Lines 33 to 39 in bed54c5
Please help to close if you agree that's a good approach |
Yeah, that looks like a good pattern. Do you plan to wrap that up a bit more into a reusable function? |
do you have in mind an exported lint_repo() function? or an argument to lint_package()/lint_dir() my first instinct was just better documentation (esp. if our workflow is added as a template in r-lib/actions) |
The advantage of making it a function is that once it gets baked into |
Currently, https://github.com/r-lib/lintr/blob/main/.github/workflows/lint.yaml doesn't actually do anything because
lint_package()
never errors. Should it? Or should there be another function that's designed specifically for CI scenarios?The text was updated successfully, but these errors were encountered: