Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chapter 2 review #308

Merged
merged 2 commits into from
Jan 4, 2025
Merged

chapter 2 review #308

merged 2 commits into from
Jan 4, 2025

Conversation

tgerke
Copy link
Collaborator

@tgerke tgerke commented Jan 3, 2025

mostly light copy edits

@tgerke
Copy link
Collaborator Author

tgerke commented Jan 3, 2025

One question though: can we time-order that example DAG throughout? I know that's something we want to emphasize later on (and that's a good practice!) but I don't have enough ggdag-fu to make it look good for this example

@tgerke tgerke requested a review from malcolmbarrett January 3, 2025 17:39
Copy link
Collaborator

@malcolmbarrett malcolmbarrett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made some small changes, but a big one is that I reverted to group_by().

I also have a list of stylistic consistency decisions I am going to post as an issue so we can all be on the same page about them. I'd rather make those types of decisions comprehensively rather than as a suggestion on a PR

@@ -410,7 +410,7 @@ In this example, we'll focus on weighting.
In particular, we'll compute the inverse probability weight for the **average treatment effect (ATE)**.
The ATE represents a particular causal question: what if *everyone* in the study used bed nets vs. what if *no one* in the study used bed nets?

To calculate the ATE, we'll use the broom and propensity packages.
To calculate the ATE, we'll use the {[broom](https://broom.tidymodels.org/)} and {[propensity](https://github.com/r-causal/propensity)} packages.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I recently discovered that if you do `{pkgname}` in Quarto, this will happen automatically

@malcolmbarrett malcolmbarrett merged commit 9728f24 into main Jan 4, 2025
1 check passed
@malcolmbarrett malcolmbarrett deleted the tg-edits branch January 4, 2025 14:07
@malcolmbarrett
Copy link
Collaborator

Oh, re: time-ordering, you already made this suggestions and we decided to keep it as is because that is Andrew's DAG. That said, I'll file an issue because I'm going to make some improvements to the time-ordering algorithm that might make this easier to do automatically for a DAG like this. So we can re-explore soon

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants