Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ggdag code overhaul and style consistency #244

Open
malcolmbarrett opened this issue Jun 19, 2024 · 0 comments
Open

ggdag code overhaul and style consistency #244

malcolmbarrett opened this issue Jun 19, 2024 · 0 comments

Comments

@malcolmbarrett
Copy link
Collaborator

malcolmbarrett commented Jun 19, 2024

Once ggdag 0.3.0 is out, I'll need to overhaul the syntax here. Currently, it's a mix of newer and older ways of doing things.

Relatedly, in #243, I found that our habit of using a modified label geom wasn't working well for the more complex alternative DAGs in that chapter, so I explored a different style using a text repel and lighter arrows. I also learned recently that ggrepel has a newish way of having a bit more control over the repulsion that looks appealing for DAGs. So, I'd like to make sure that we're consistent with what we do, although I don't think there's one way that will always be best. This approach may have an issue with visibility for those with visual impairments because of the light-on-light colors. I'm not sure.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant