Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

klarnaservices breaks hottopic site #27

Open
hyder365 opened this issue Apr 25, 2023 · 7 comments
Open

klarnaservices breaks hottopic site #27

hyder365 opened this issue Apr 25, 2023 · 7 comments

Comments

@hyder365
Copy link

Hi. I'm re-filing this issue: StevenBlack/hosts#2309 here since your list seems to be the source of the problem. tl;dr klarnaservices.com is needed for hottopic.com to function properly.

@r-a-y
Copy link
Owner

r-a-y commented Apr 26, 2023

I would say please report this issue over at EasyList. See easylist/easylist#12488.

At the moment, you should use your DNS blocker to allow the klarnaservices.com domain. If the issue is that klarnaservices.com is required and is blocking things other than images, let me know and I might consider allowing the domain as an exception.

@hyder365
Copy link
Author

I'm using your list with unbound to block ad/tracking domains. klarnaservices is required for the functionality of the website I listed. I'm not using anything directly from easylist, just your file with the domain list.

@r-a-y
Copy link
Owner

r-a-y commented Apr 26, 2023

The EasyPrivacy3rdParty file is converted over and sourced from EasyPrivacy. The issue is with their rule that was added on October 26, 2019: easylist/easylist@b553d0c.

You should create an issue over at EasyList and reference the commit I mentioned.

@hagezi
Copy link

hagezi commented Apr 26, 2023

@r-a-y
The Easylist rule has the $image modifier, ||klarnaservices.com^$image,third-party which is fine. You should not extract such rules for DNS lists. This is not an EasyList issue.

@hagezi
Copy link

hagezi commented Apr 26, 2023

@r-a-y
For DNS lists only extract rules with the following modifiers:

  • $1p
  • $third-party and $3p be cautious with this. Blindly removing $third-party from ad blocking rules leads to lots of false-positives.
  • $document and $doc
  • $all
  • $popup

@r-a-y
Copy link
Owner

r-a-y commented Apr 26, 2023

I think the problem is using my lists with DNS blockers that block entire domains as well as subdomains.

I checked the hottopic.com site and the https://na-library.klarnaservices.com is called. When using as a HOSTS file, the klarnaservices.com main domain should be blocked only. See the adblock filter syntax: https://help.adblockplus.org/hc/en-us/articles/360062733293-How-to-write-filters#anchors.

When using with blockers like Unbound, subdomains from klarnaservices.com would be blocked as well. So this is more of a documentation and user awareness problem. You shouldn't really be using my EasyPrivacy-converted list with DNS blockers. If you want to use a list made for DNS, stick with the Adblock DNS filter from this repo only. My repo is called "Mobile Hosts" after all.

Also I do admit that my converter is aggressive. That is intentional. I might relax the rules for the converter in the future

@hagezi
Copy link

hagezi commented Apr 26, 2023

That may be, but it does not change the fact that you should not extract rules for DNS with certain modifiers from adblock lists.
You provide a converted AdBlock list in host format. If you use the Adblock version, klarnaservices.com will not be blocked, if you use your converted host version, it will be blocked. This does not fit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants