Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support multisite #94

Open
bricoll opened this issue Mar 6, 2017 · 3 comments
Open

Support multisite #94

bricoll opened this issue Mar 6, 2017 · 3 comments

Comments

@bricoll
Copy link

bricoll commented Mar 6, 2017

Edited by r-a-y:

RBE currently only works on the main BuddyPress site, but it might be advantageous to support sub-sites so plugins like bbPress will work.

Would have to add the blog ID to the Reply-To email header and do some checks to see if bbPress will work accordingly.


Original report:

R-a-y,

Attached is a screenshot of debug log. Tried posting at 24:26 from outlook and at 30:40 from gmail. Neither reply posted to the forum.

Have successfully implemented your plugin on single site installation, so am familiar with the process.

Any idea what the problem might be?

--B
capture

@bricoll
Copy link
Author

bricoll commented Mar 10, 2017

Follow up:

The problem described above is actually limited to replies by email for a forum on the secondary domain of the multisite install. Replies by email for forums on the primary site work fine.

Is this a known issue?

@r-a-y
Copy link
Owner

r-a-y commented Mar 14, 2017

Yes, this is a known issue. See #24 where I mention this.

Unfortunately, I will not be able to work on this for awhile due to other things taking priority, but I will get to this eventually.

In the meantime, perhaps only activate RBE on the main site instead of network-wide.

@r-a-y r-a-y changed the title replies fail to post on multisite installation bbPress: Forum replies fail to post for secondary sites on multisite Mar 14, 2017
@r-a-y r-a-y changed the title bbPress: Forum replies fail to post for secondary sites on multisite Support multisite Apr 10, 2018
r-a-y added a commit that referenced this issue Apr 10, 2018
r-a-y added a commit that referenced this issue Apr 10, 2018
Adds the 'b' parameter to the email address, which is for the current blog
ID, so we can determine which blog this topic should be posted to.

See #94.
r-a-y added a commit that referenced this issue Apr 10, 2018
Previously, using wp_upload_dir() on multisite would result in a different
log created for each sub-site.

This might be advantageous in certain situations, but it's better to have
everything log into one place.  For this, we're going to use BP's
`bp_core_avatar_upload_path()` function.

See #94.
r-a-y added a commit that referenced this issue Apr 12, 2018
…o reply via email.

It's possible that the sub-site might no longer have bbPress active.  If
that occurs, we should stop the RBE process and send an error email back to
the user.

See #94.
r-a-y added a commit that referenced this issue Apr 12, 2018
Since we're calling bp_core_avatar_upload_path() before 'bp_setup_globals',
we need to declare buddypress()->avatar to avoid notices since this isn't
done in BuddyPress.  View commit 2aec99e where this was introduced.

See https://buddypress.trac.wordpress.org/browser/tags/2.9.4/src/bp-core/bp-core-avatars.php?marks=1550,1573#L1546

See #94.
@r-a-y
Copy link
Owner

r-a-y commented Apr 25, 2018

@bricoll - Give v1.0-RC6 a try on multisite and report back.

This will take effect for newer forum posts, not older ones.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants