Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve runtests and CI pipeline #38

Merged
merged 5 commits into from
Mar 29, 2024
Merged

Conversation

ytdHuang
Copy link
Member

Here are the summary changes for this PR, which I think is quite necessary to do before getting more and more people involved to contribute to this package.

  1. Separate different testsets into individual files, which would be better for everyone to cooperate in the future
  2. use SafeTestsets to make all testsets be really independent with each other (I found some small bugs in the original runtests, like one is using the variables in another testset)
  3. Separate the CI pipeline into runtests and documentation
  4. For both CIs, I changed the situations for triggering them, and also automatically skip for draft PR
  5. For runtests CI, I add the os (MacOS and Windows)
  6. For runtests CI, I add the keyword group: Core, to specify that we are testing core functionalities for our packages (this is just in case that we might have extensions in the future)

I'm making these changes based on my habits, of course it doesn't necessarily to do it in my way.

Copy link

codecov bot commented Mar 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.74%. Comparing base (e19924e) to head (93687f8).

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #38   +/-   ##
=======================================
  Coverage   89.74%   89.74%           
=======================================
  Files          17       17           
  Lines        1619     1619           
=======================================
  Hits         1453     1453           
  Misses        166      166           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@albertomercurio albertomercurio merged commit edc6481 into qutip:main Mar 29, 2024
12 checks passed
@ytdHuang ytdHuang deleted the opt/runtests branch March 29, 2024 07:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants