Improved Floquet solver #153
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #153 +/- ##
==========================================
+ Coverage 91.97% 92.42% +0.44%
==========================================
Files 26 26
Lines 1795 1835 +40
==========================================
+ Hits 1651 1696 +45
+ Misses 144 139 -5 ☔ View full report in Codecov by Sentry. |
albertomercurio
approved these changes
Jun 1, 2024
|
Does these steady state solving methods have any reference paper? Maybe we should add the reference in the docstrings. It would be easier for the users to follow. Apart from that, everything is fine~ |
ytdHuang
approved these changes
Jun 2, 2024
src/steadystate.jl
Outdated
| ω::Real; n_max::Int=4, | ||
| tol::Real=1e-15, | ||
| ss_solver::SteadyStateSolver=SteadyStateDirectSolver()) | ||
| function steadystate_floquet( |
There was a problem hiding this comment.
I think we dont need to put the word "function" here
There was a problem hiding this comment.
Thank you very much. I am going to remove it as soon as possible.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this pull request, we fix #82.
With this new method, we can solve the entire linear system at once and we can also get the other Fourier components of the density matrix.
I have also introduced a little explanation in the documentation.
In the next pull requests, we could also return the other Fourier components using the
SSFloquetEffectiveLiouvilliansolver, since this was not the aim of the original issue.