Fix incorrect initial DCID indexing on retried connections #1946
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This could also cause other packets received before the server accepts the connection to be lost.
Ralith
force-pushed
the
fix-incoming-retry
branch
from
68b3db0
to
edb79f0
Compare
Ralith
changed the title
djc
approved these changes
Jul 31, 2024
|
Is this a regression? Why do you think no one has noticed so far? |
|
This was a regression from 0.10, yeah. I'm guessing folks aren't using retries (they add an RTT, after all), and/or the memory leak and lost packets are insignificant. |
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This could also cause other packets received before the server accepts the connection to be lost.
Noticed while checking some unrelated assumptions.