Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3 flaky tests #2095

Open
gretchenfrage opened this issue Dec 17, 2024 · 1 comment
Open

3 flaky tests #2095

gretchenfrage opened this issue Dec 17, 2024 · 1 comment

Comments

@gretchenfrage
Copy link
Collaborator

I ran cargo test on Quinn (05f6e67) 1,003,080 times. This is what I found.

There are 3 flaky tests:

  • tests::single_ack_eliciting_packet_triggers_ack_after_delay fails 0.101% of the time. I collected 1021 occurrences.

    The flakyness of this test was also noted in Flaky test: single_ack_eliciting_packet_triggers_ack_after_delay #2014.

    In one arbitrarily chosen failure, the error was this:

    thread 'tests::single_ack_eliciting_packet_triggers_ack_after_delay' panicked at quinn-proto/src/tests/mod.rs:2490:5:
    assertion `left == right` failed
      left: Instant { tv_sec: 137912, tv_nsec: 296566897 }
     right: Instant { tv_sec: 137912, tv_nsec: 218566897 }
    
  • tests::key_update_reordered fails 0.098% of the time. I collected 983 occurrences.

    The flakyness of this test was also noted in key_update_reordered is flaky #1695.

    In one arbitrarily chosen failure, the error was this:

    thread 'tests::key_update_reordered' panicked at quinn-proto/src/tests/mod.rs:1064:5:
    assertion `left == right` failed
      left: 1
     right: 0
    
  • tests::key_update_simple fails 0.015% of the time. I collected 146.

    This is the rarest of the bunch, and I wasn't able to find evidence that this has been noticed before.

    In one arbitrarily chosen failure, the error was this:

    thread 'tests::key_update_simple' panicked at quinn-proto/src/tests/mod.rs:1021:5:
    assertion failed: `None` does not match `Some(Event::Stream(StreamEvent::Readable { id })) if id == s`
    

I am attaching to this issue grouped.zip, which contains the stdout/stderr of all runs in which the tests failed, grouped by which test failed. These contain terminal color codes, so I recommend you read the files with cat.

@gretchenfrage
Copy link
Collaborator Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant