Skip to content

"unused manifest key" warning occurs upon cargo check #2004

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
gretchenfrage opened this issue Oct 8, 2024 · 4 comments
Closed

"unused manifest key" warning occurs upon cargo check #2004

gretchenfrage opened this issue Oct 8, 2024 · 4 comments

Comments

@gretchenfrage
Copy link
Collaborator

Running the main branch (commit 08ee9ee471b61fe2c7a7248dfb628b0edcf6aca9) with the latest cargo version (cargo 1.81.0 (2dbb1af80 2024-08-20), rustc 1.81.0 (eeb90cda1 2024-09-04)) emits the following warning:

warning: /home/phoenix/repos/quinn/quinn-udp/Cargo.toml: unused manifest key: target.cfg(any(target_os = "linux", target_os = "windows")).bench
@djc
Copy link
Member

djc commented Oct 8, 2024

I've also seen this, but not sure what to do about it. Cargo.toml context:

https://github.com/quinn-rs/quinn/blob/main/quinn-udp/Cargo.toml#L35

throughput benchmark using Criterion:

https://github.com/quinn-rs/quinn/blob/main/quinn-udp/benches/throughput.rs

(Asked t-cargo for suggestions on Zulip: https://rust-lang.zulipchat.com/#narrow/stream/246057-t-cargo/topic/.22unused.20manifest.20key.22.)

@mxinden
Copy link
Collaborator

mxinden commented Oct 10, 2024

Might be resolved through #2010 which fixes the invalid cfg.

I introduced this in #1915. Sorry about that.

@Ralith
Copy link
Collaborator

Ralith commented Oct 25, 2024

Is this fixed?

@gretchenfrage
Copy link
Collaborator Author

Yes, this appears to be fixed :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants