Skip to content

DatagramState::drop_oversized should update DatagramState::outgoing_total #1985

Closed
@dongcarl

Description

@dongcarl

I could be mistaken, but it seems that DatagramState::outgoing_total is updated every time DatagramState::outgoing is touched, except for in DatagramState::drop_oversized, is there a reason for this?

pub(super) fn drop_oversized(&mut self, max_payload: usize) {
self.outgoing.retain(|datagram| {
let result = datagram.data.len() < max_payload;
if !result {
trace!(
"dropping {} byte datagram violating {} byte limit",
datagram.data.len(),
max_payload
);
}
result
});
}

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions