Make bwc test fail if anything changes (#3375)

Fixes regression that was missing changes in the current serialization
version.

Fixes #3374

Author: imotov

quickwit/quickwit-metastore/src/backward_compatibility_tests/mod.rs

@@ -145,11 +145,40 @@ where for<'a> T: Serialize {
     let mut sample_json = serde_json::to_string_pretty(&sample_json_value)?;
     sample_json.push('\n');
     let test_name = format!("v{version}");
-    let file_regression_test_path = format!("{}/{}.json", test_dir.display(), test_name);
-    let file_regression_expected_path =
+    let file_regression_test_path_str = format!("{}/{}.json", test_dir.display(), test_name);
+    let file_regression_expected_path_str =
         format!("{}/{}.expected.json", test_dir.display(), test_name);
-    std::fs::write(file_regression_test_path, sample_json.as_bytes())?;
-    std::fs::write(file_regression_expected_path, sample_json.as_bytes())?;
+
+    let file_regression_test_path = Path::new(&file_regression_test_path_str);
+    let (changes_detected, file_created) = if file_regression_test_path.try_exists()? {
+        let expected_old_json_value: JsonValue = deserialize_json_file(file_regression_test_path)?;
+        let expected_new_json_value: JsonValue = serde_json::from_str(&sample_json)?;
+        (expected_old_json_value != expected_new_json_value, false)
+    } else {
+        (false, true)
+    };
+
+    if changes_detected || file_created {
+        std::fs::write(
+            file_regression_test_path_str.clone(),
+            sample_json.as_bytes(),
+        )?;
+        std::fs::write(
+            file_regression_expected_path_str.clone(),
+            sample_json.as_bytes(),
+        )?;
+        if file_created {
+            panic!(
+                "The following files need to be added: {file_regression_test_path_str:?} and \
+                 {file_regression_expected_path_str:?}"
+            )
+        } else {
+            panic!(
+                "The following files need to be updated: {file_regression_test_path_str:?} and \
+                 {file_regression_expected_path_str:?}"
+            )
+        }
+    }
     Ok(())
 }
 

quickwit/quickwit-metastore/test-data/file-backed-index/v0.6.expected.json

@@ -4,7 +4,7 @@
       "create_timestamp": 0,
       "delete_query": {
         "index_uid": "index:1111111111111",
-        "query_ast": "{\"type\":\"Bool\",\"must\":[{\"type\":\"Phrase\",\"field\":\"body\",\"phrase\":\"Harry\"},{\"type\":\"Phrase\",\"field\":\"body\",\"phrase\":\"Potter\"}]}"
+        "query_ast": "{\"type\":\"bool\",\"must\":[{\"type\":\"full_text\",\"field\":\"body\",\"text\":\"Harry\",\"params\":{\"mode\":{\"type\":\"phrase\"}}},{\"type\":\"full_text\",\"field\":\"body\",\"text\":\"Potter\",\"params\":{\"mode\":{\"type\":\"phrase\"}}}]}"
       },
       "opstamp": 10
     }

quickwit/quickwit-metastore/test-data/file-backed-index/v0.6.json

@@ -4,7 +4,7 @@
       "create_timestamp": 0,
       "delete_query": {
         "index_uid": "index:1111111111111",
-        "query_ast": "{\"type\":\"Bool\",\"must\":[{\"type\":\"Phrase\",\"field\":\"body\",\"phrase\":\"Harry\"},{\"type\":\"Phrase\",\"field\":\"body\",\"phrase\":\"Potter\"}]}"
+        "query_ast": "{\"type\":\"bool\",\"must\":[{\"type\":\"full_text\",\"field\":\"body\",\"text\":\"Harry\",\"params\":{\"mode\":{\"type\":\"phrase\"}}},{\"type\":\"full_text\",\"field\":\"body\",\"text\":\"Potter\",\"params\":{\"mode\":{\"type\":\"phrase\"}}}]}"
       },
       "opstamp": 10
     }