Skip to content

Commit e88acdb

Browse files
authored
Merge pull request #129 from quickwit-oss/ddelemeny/fix-context-variable-queries
Disable lint filter in context editor
2 parents 6628ce2 + 9f9a2ff commit e88acdb

File tree

1 file changed

+7
-5
lines changed

1 file changed

+7
-5
lines changed

src/LogContext/components/LogContextUI.tsx

Lines changed: 7 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -49,8 +49,8 @@ export interface LogContextUIProps extends LogContextProps {
4949

5050
export function LogContextUI(props: LogContextUIProps ){
5151
const builder = useQueryBuilder();
52-
const {query, parsedQuery, setQuery, setParsedQuery} = builder;
53-
const [canRunQuery, setCanRunQuery] = useState<boolean>(false);
52+
const {query, /*parsedQuery,*/ setQuery, setParsedQuery} = builder;
53+
const [canRunQuery, /*setCanRunQuery*/] = useState<boolean>(true);
5454
const {row, origQuery, updateQuery, runContextQuery } = props;
5555

5656
const fieldsSuggestionTimeRange = useMemo(()=>createContextTimeRange(row.timeEpochMs), [row])
@@ -60,9 +60,11 @@ export function LogContextUI(props: LogContextUIProps ){
6060
setQuery(origQuery?.query || '')
6161
}, [setQuery, origQuery])
6262

63-
useEffect(()=>{
64-
setCanRunQuery(!parsedQuery.parseError)
65-
}, [parsedQuery, setCanRunQuery])
63+
// FIXME : query parser used for lint is not reliable enough
64+
// to use as a filter for wrong queries. Disabled for now.
65+
// useEffect(()=>{
66+
// <setCanRunQuery(!parsedQuery.parseError)
67+
// }, [parsedQuery, setCanRunQuery])
6668

6769
const runQuery = useCallback(()=>{
6870
if (runContextQuery){

0 commit comments

Comments
 (0)