Skip to content

Commit 320e733

Browse files
committed
Fix useDatasourceFields calls with timeRange
1 parent ab85052 commit 320e733

File tree

2 files changed

+5
-6
lines changed

2 files changed

+5
-6
lines changed

src/LogContext/components/LogContextUI.tsx

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
import React, { useEffect, useState, useCallback, useMemo } from "react";
2-
import { LogRowModel, Field as GrafanaField, getDefaultTimeRange } from '@grafana/data';
2+
import { LogRowModel, Field as GrafanaField } from '@grafana/data';
33
import { ElasticsearchQuery as DataQuery } from '../../types';
44
import { LuceneQueryEditor } from "../../components/LuceneQueryEditor";
55

@@ -54,8 +54,6 @@ export function LogContextUI(props: LogContextUIProps ){
5454
const {row, origQuery, updateQuery, runContextQuery } = props;
5555

5656
const fieldsSuggestionTimeRange = useMemo(()=>createContextTimeRange(row.timeEpochMs), [row])
57-
const defaultTimeRange = getDefaultTimeRange()
58-
console.log("RANGES", fieldsSuggestionTimeRange, defaultTimeRange)
5957
const {fields, getSuggestions} = useDatasourceFields(props.datasource, fieldsSuggestionTimeRange);
6058

6159
useEffect(()=>{

src/datasource/utils.ts

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -17,9 +17,10 @@ export type Suggestion = {
1717

1818
export function useDatasourceFields(datasource: BaseQuickwitDataSource, range: TimeRange) {
1919
const [fields, setFields] = useState<MetricFindValue[]>([]);
20+
2021
useEffect(() => {
2122
if (datasource.getTagKeys) {
22-
datasource.getTagKeys({ searchable: true, range: range}).then(setFields);
23+
datasource.getTagKeys({ searchable: true, timeRange: range}).then(setFields);
2324
}
2425
}, [datasource, range, setFields]);
2526

@@ -29,7 +30,7 @@ export function useDatasourceFields(datasource: BaseQuickwitDataSource, range: T
2930
const wordIsField = word.match(/([^:\s]+):"?([^"\s]*)"?/);
3031
if (wordIsField?.length) {
3132
const [_match, fieldName, _fieldValue] = wordIsField;
32-
const candidateValues = await datasource.getTagValues({ key: fieldName });
33+
const candidateValues = await datasource.getTagValues({ key: fieldName, timeRange: range });
3334
suggestions.from = fieldName.length + 1; // Replace only the value part
3435
suggestions.options = candidateValues.map(v => ({
3536
type: 'text',
@@ -46,7 +47,7 @@ export function useDatasourceFields(datasource: BaseQuickwitDataSource, range: T
4647
}
4748
return suggestions;
4849

49-
}, [datasource, fields]);
50+
}, [datasource, fields, range]);
5051

5152
return {fields, getSuggestions}
5253
}

0 commit comments

Comments
 (0)