Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove simd bitpacking implementations for high bit width #47

Open
fulmicoton opened this issue Sep 13, 2023 · 2 comments
Open

Remove simd bitpacking implementations for high bit width #47

fulmicoton opened this issue Sep 13, 2023 · 2 comments
Assignees
@trinity-1686a
Labels
good first issue Good for newcomers

Comments

@fulmicoton
Copy link
Contributor

For sorted stuff, having a super fast implementation is not necessary above bitwidth = 8. We can fallback to the scalar implementation.
For unsorted stuff, I think we can also restrict ourselves to bitwidth <= 8, although this is a trade-off.
@fulmicoton fulmicoton added the good first issue Good for newcomers label Sep 13, 2023
@PSeitz
Copy link
Contributor

PSeitz commented Nov 19, 2023

The amount of generated code seems excessive currently

➜  bitpacking git:(master) cargo expand | wc -l

330128

@fulmicoton
Copy link
Contributor Author

Definitely :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@trinity-1686a trinity-1686a

Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@fulmicoton @PSeitz @trinity-1686a