Do we need a mutex in FieldMap ?

[sylr]

In #485 a mutex has been added to FieldMap to make it Thread Safe.

However, in the same PR, the Message pool mechanism has also been removed so Messages are not re-used any longer and it's up to the Go garbage collector to free unused messages.

In that context I fail to see a scenario where a Message and the underlying FieldMaps need to be thread safe.

Can someone share a use case where a message is concurrently read/updated ?

cc @waheedoo @ackleymi

[matejsp]

I was asking myself the same question. We got bitten by slow reads from parsed message since every field is protected mutex lock slowing down the processing.
I would prefer no locking of messages especially if they are no longer reused.

If you need to lock the FieldMap you should do it outside in your own code (this would also improve when getting or setting multiple fields).

[sylr]

@waheedoo @ackleymi could we get your input on this matter.