Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warn user if they @select a column which doesn't exist #286

Open
metanoid opened this issue Oct 4, 2019 · 2 comments
Open

Warn user if they @select a column which doesn't exist #286

metanoid opened this issue Oct 4, 2019 · 2 comments
Milestone

Comments

@metanoid
Copy link

metanoid commented Oct 4, 2019

If the user specifies named columns to @select, and any of those columns do not exist, the macro does not provide a warning.

For example, I wanted to get two named columns from a DataFrame called df:

df |> @select(:first_col, :secon_col) # note mis-spelling of `second_col`

Actual behaviour:
This returned a query result with only first_col.
Expected behaviour:
Show a warning like No column "secon_col" in source, and then return a query result with only first_col

@davidanthoff davidanthoff added this to the Backlog milestone Oct 5, 2019
@davidanthoff
Copy link
Member

I think we could even throw an error in this case.

@AliMalik9599
Copy link

Hi @davidanthoff I am interested in working on this issue if it has not been completed already. Any advice on getting started? I am thinking of just displaying a warning message as long as one of the arguments is valid. Thanks for the help!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants