Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Serializer with map-contents for slots yields empty results with existing Element #5

Closed
maur-o opened this issue Jun 10, 2024 · 0 comments · Fixed by #7
Closed

Serializer with map-contents for slots yields empty results with existing Element #5

maur-o opened this issue Jun 10, 2024 · 0 comments · Fixed by #7
Assignees
@jwloka
Labels
bug Something isn't working

Comments

@maur-o
Copy link
Member

maur-o commented Jun 10, 2024

Serializer should always yield markup for existing "root" Elements.

It does not make sense to return empty for an existing element and it is confusing.
@maur-o maur-o added the bug Something isn't working label Jun 10, 2024
@jwloka jwloka self-assigned this Jun 13, 2024
@jwloka jwloka changed the title Serializer with map-children yield empty for existing Element Serializer with map-contents for slots yields empty results with existing Element Aug 17, 2024
jwloka added a commit that referenced this issue Aug 17, 2024
@jwloka
Serializer with map-children yield empty for existing Element
85df7cd 
Fixes #5
jwloka added a commit that referenced this issue Aug 17, 2024
@jwloka
t Provides tests to show that srializer reveals root element with map…
e08ba70 
…-contents true

Fixes #5
@jwloka jwloka mentioned this issue Aug 17, 2024
Merged
@jwloka jwloka closed this as completed in #7 Aug 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jwloka jwloka

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
2 participants
@jwloka @maur-o