Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Usage of make-process in quarto-preview #19

Open
fast-90 opened this issue Jun 15, 2023 · 1 comment
Open

Usage of make-process in quarto-preview #19

fast-90 opened this issue Jun 15, 2023 · 1 comment

Comments

@fast-90
Copy link

fast-90 commented Jun 15, 2023

Is there any reason to use make-process over start-process-shell-command in the quarto-preview defun? For some reason I am unable to get quarto-preview to work for me as it does not recognise my Jupyter Kernel, however when I open shell and run quarto preview manually it works as expected. I suspect this is because make-process is not reading some of my environment variables related to virtualenv correctly (the problem may be similar to #16).

I am able to get it work with start-process-shell-command in my own config, but I wonder if it is something worth considering to implement in the package? Happy to submit a PR, but I just wanted to check this point before I attempt it as I'm not sure on the differences between the two process related commands.

@cscheid
Copy link
Contributor

cscheid commented Jun 20, 2023

I'm not sure what the end result will look like in your PR, so I can't promise we'll merge. But I definitely will take a serious look at it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants