Cool stuff!

I'll have a close look at the PR when I'm back (in 10 days or so)

We need documentation/guide for this new extension too

This will be really useful, IMO. The code looks similar to the patterns I was able to work out for #42535, so to my knowledge, it's correct. :) We should include a reference to this in the dev services doc as a nice clean example, once it merges.

I have a few little questions:

Reuse + mapped ports

I wonder if false is the right default for reuse, in the presence of mapped ports? I found live reload pretty intolerable with fixed ports and reuse false. But have a default change depending on other values is complex, so maybe we just document that people should turn reuse off if they set the port? But that leads me to ...

Documentation

There doesn't seem to be any. :)

Reuse, again

I noticed that a lot of the extensions which reused containers, like ElasticSearch, did really complex things about storing static variables and customising shutdown. I think part of that comes when the container is shared across several instances, so maybe we can ignore all that, but I did feel uneasy that my example service was so much simpler than the ones in the Quarkus codebase. The same worry applies here, and @gsmet did imply some of the complexity was necessary - but maybe it's just a question of articulating when the complexity is needed and when it's not.

Extension name

My main question is about the name. I wonder if users might think they need to add this extension, to get dev services? And I wonder if extension-developers might get confused about what the difference is between this and dev-services-common? I don't have any very good suggestions, though - dev-services-config or config-dev-services makes it sound like something for configuring dev services, configurable-dev-services is clearer but not that clear and it's awfully long, and has the words in the wrong order. dev-services-easy or dev-services-quick or something might make the intention clear?

🎊 PR Preview 6b0a25d has been successfully built and deployed to https://quarkus-pr-main-42587-preview.surge.sh/version/main/guides/

• Images of blog posts older than 3 months are not available.
• Newsletters older than 3 months are not available.

agree with @holly-cummins there is a lot of code that checks for "shared" dev services etc and proper shutdown. I follow those patterns because a lot of the built in Quarkus Dev Services follow that pattern.

Hi @holly-cummins , @gastaldi , @melloware . Thanks for your feedback.

@gastaldi - I applied your suggestions.
@holly-cummins:

Reuse + mapped ports
So will this be a better default:

// Reuse
// If not provided, and the mapped port is configured, we want reuse true as a default, else false
if(config.reuse().isPresent()){
    container = container.withReuse(config.reuse().get());
}else if(config.mappedPort().isPresent()){
    container = container.withReuse(true);
}else{
    container = container.withReuse(false);
}

Documentation
Yes, I was thinking to do this in another PR.

Reuse, again
So I am sure there will be cases that this "User defined dev services" will not work, not just from a reuse p.o.v. but from any other aspect. For those cases, you will need to write an extension. This target simple cases, and private / homegrown cases, example, I have 3 microservices, all written in Java and all containerized and available to be pulled with podman/docker. One service needs the other two to run, so I can configure them here and my app will just work in dev mode. (something like that?)

Extension name
I actually initially had this extension as a separate extension, but then I saw there is already a quarkus-devservices extension, it just did not have a runtime module. I am happy either way, we can move it to it's own extension (something like quarkus-user-devservices or quarkus-app-devservices. Just let me know. It could even be in quarkiverse

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit b60ab6d.

Failing Jobs

You can consult the Develocity build scans.

Failures

⚙️ Initial JDK 17 Build #

- Failing: extensions/agroal/runtime extensions/elasticsearch-rest-client-common/runtime extensions/infinispan-client/runtime and 16 more
! Skipped: devtools/bom-descriptor-json docs extensions/agroal/deployment and 324 more

📦 extensions/agroal/runtime

✖ Failed to execute goal io.quarkus:quarkus-extension-maven-plugin:999-SNAPSHOT:extension-descriptor (generate-extension-descriptor) on project quarkus-agroal: The deployment artifact io.quarkus:quarkus-agroal-deployment::jar depends on the following Quarkus extension deployment artifacts whose corresponding runtime artifacts were not found among the dependencies of io.quarkus:quarkus-agroal:jar:999-SNAPSHOT: io.quarkus:quarkus-devservices-deployment::jar

📦 extensions/elasticsearch-rest-client-common/runtime

✖ Failed to execute goal io.quarkus:quarkus-extension-maven-plugin:999-SNAPSHOT:extension-descriptor (generate-extension-descriptor) on project quarkus-elasticsearch-rest-client-common: The deployment artifact io.quarkus:quarkus-elasticsearch-rest-client-common-deployment::jar depends on the following Quarkus extension deployment artifacts whose corresponding runtime artifacts were not found among the dependencies of io.quarkus:quarkus-elasticsearch-rest-client-common:jar:999-SNAPSHOT: io.quarkus:quarkus-devservices-deployment::jar

📦 extensions/infinispan-client/runtime

✖ Failed to execute goal io.quarkus:quarkus-extension-maven-plugin:999-SNAPSHOT:extension-descriptor (generate-extension-descriptor) on project quarkus-infinispan-client: The deployment artifact io.quarkus:quarkus-infinispan-client-deployment::jar depends on the following Quarkus extension deployment artifacts whose corresponding runtime artifacts were not found among the dependencies of io.quarkus:quarkus-infinispan-client:jar:999-SNAPSHOT: io.quarkus:quarkus-devservices-deployment::jar

📦 extensions/kafka-client/runtime

✖ Failed to execute goal io.quarkus:quarkus-extension-maven-plugin:999-SNAPSHOT:extension-descriptor (generate-extension-descriptor) on project quarkus-kafka-client: The deployment artifact io.quarkus:quarkus-kafka-client-deployment::jar depends on the following Quarkus extension deployment artifacts whose corresponding runtime artifacts were not found among the dependencies of io.quarkus:quarkus-kafka-client:jar:999-SNAPSHOT: io.quarkus:quarkus-devservices-deployment::jar

📦 extensions/kubernetes-client/runtime-internal

✖ Failed to execute goal io.quarkus:quarkus-extension-maven-plugin:999-SNAPSHOT:extension-descriptor (generate-extension-descriptor) on project quarkus-kubernetes-client-internal: The deployment artifact io.quarkus:quarkus-kubernetes-client-internal-deployment::jar depends on the following Quarkus extension deployment artifacts whose corresponding runtime artifacts were not found among the dependencies of io.quarkus:quarkus-kubernetes-client-internal:jar:999-SNAPSHOT: io.quarkus:quarkus-devservices-deployment::jar

📦 extensions/mongodb-client/runtime

✖ Failed to execute goal io.quarkus:quarkus-extension-maven-plugin:999-SNAPSHOT:extension-descriptor (generate-extension-descriptor) on project quarkus-mongodb-client: The deployment artifact io.quarkus:quarkus-mongodb-client-deployment::jar depends on the following Quarkus extension deployment artifacts whose corresponding runtime artifacts were not found among the dependencies of io.quarkus:quarkus-mongodb-client:jar:999-SNAPSHOT: io.quarkus:quarkus-devservices-deployment::jar

📦 extensions/observability-devservices/runtime

✖ Failed to execute goal io.quarkus:quarkus-extension-maven-plugin:999-SNAPSHOT:extension-descriptor (generate-extension-descriptor) on project quarkus-observability-devservices: The deployment artifact io.quarkus:quarkus-observability-devservices-deployment::jar depends on the following Quarkus extension deployment artifacts whose corresponding runtime artifacts were not found among the dependencies of io.quarkus:quarkus-observability-devservices:jar:999-SNAPSHOT: io.quarkus:quarkus-devservices-deployment::jar

📦 extensions/oidc-client/runtime

✖ Failed to execute goal io.quarkus:quarkus-extension-maven-plugin:999-SNAPSHOT:extension-descriptor (generate-extension-descriptor) on project quarkus-oidc-client: The deployment artifact io.quarkus:quarkus-oidc-client-deployment::jar depends on the following Quarkus extension deployment artifacts whose corresponding runtime artifacts were not found among the dependencies of io.quarkus:quarkus-oidc-client:jar:999-SNAPSHOT: io.quarkus:quarkus-devservices-deployment::jar

📦 extensions/oidc/runtime

✖ Failed to execute goal io.quarkus:quarkus-extension-maven-plugin:999-SNAPSHOT:extension-descriptor (generate-extension-descriptor) on project quarkus-oidc: The deployment artifact io.quarkus:quarkus-oidc-deployment::jar depends on the following Quarkus extension deployment artifacts whose corresponding runtime artifacts were not found among the dependencies of io.quarkus:quarkus-oidc:jar:999-SNAPSHOT: io.quarkus:quarkus-devservices-deployment::jar

📦 extensions/reactive-datasource/runtime

✖ Failed to execute goal io.quarkus:quarkus-extension-maven-plugin:999-SNAPSHOT:extension-descriptor (generate-extension-descriptor) on project quarkus-reactive-datasource: The deployment artifact io.quarkus:quarkus-reactive-datasource-deployment::jar depends on the following Quarkus extension deployment artifacts whose corresponding runtime artifacts were not found among the dependencies of io.quarkus:quarkus-reactive-datasource:jar:999-SNAPSHOT: io.quarkus:quarkus-devservices-deployment::jar

📦 extensions/redis-client/runtime

✖ Failed to execute goal io.quarkus:quarkus-extension-maven-plugin:999-SNAPSHOT:extension-descriptor (generate-extension-descriptor) on project quarkus-redis-client: The deployment artifact io.quarkus:quarkus-redis-client-deployment::jar depends on the following Quarkus extension deployment artifacts whose corresponding runtime artifacts were not found among the dependencies of io.quarkus:quarkus-redis-client:jar:999-SNAPSHOT: io.quarkus:quarkus-devservices-deployment::jar

📦 extensions/schema-registry/apicurio/avro/runtime

✖ Failed to execute goal io.quarkus:quarkus-extension-maven-plugin:999-SNAPSHOT:extension-descriptor (generate-extension-descriptor) on project quarkus-apicurio-registry-avro: The deployment artifact io.quarkus:quarkus-apicurio-registry-avro-deployment::jar depends on the following Quarkus extension deployment artifacts whose corresponding runtime artifacts were not found among the dependencies of io.quarkus:quarkus-apicurio-registry-avro:jar:999-SNAPSHOT: io.quarkus:quarkus-devservices-deployment::jar

📦 extensions/schema-registry/apicurio/json-schema/runtime

✖ Failed to execute goal io.quarkus:quarkus-extension-maven-plugin:999-SNAPSHOT:extension-descriptor (generate-extension-descriptor) on project quarkus-apicurio-registry-json-schema: The deployment artifact io.quarkus:quarkus-apicurio-registry-json-schema-deployment::jar depends on the following Quarkus extension deployment artifacts whose corresponding runtime artifacts were not found among the dependencies of io.quarkus:quarkus-apicurio-registry-json-schema:jar:999-SNAPSHOT: io.quarkus:quarkus-devservices-deployment::jar

📦 extensions/schema-registry/confluent/avro/runtime

✖ Failed to execute goal io.quarkus:quarkus-extension-maven-plugin:999-SNAPSHOT:extension-descriptor (generate-extension-descriptor) on project quarkus-confluent-registry-avro: The deployment artifact io.quarkus:quarkus-confluent-registry-avro-deployment::jar depends on the following Quarkus extension deployment artifacts whose corresponding runtime artifacts were not found among the dependencies of io.quarkus:quarkus-confluent-registry-avro:jar:999-SNAPSHOT: io.quarkus:quarkus-devservices-deployment::jar

📦 extensions/schema-registry/confluent/json-schema/runtime

✖ Failed to execute goal io.quarkus:quarkus-extension-maven-plugin:999-SNAPSHOT:extension-descriptor (generate-extension-descriptor) on project quarkus-confluent-registry-json-schema: The deployment artifact io.quarkus:quarkus-confluent-registry-json-schema-deployment::jar depends on the following Quarkus extension deployment artifacts whose corresponding runtime artifacts were not found among the dependencies of io.quarkus:quarkus-confluent-registry-json-schema:jar:999-SNAPSHOT: io.quarkus:quarkus-devservices-deployment::jar

📦 extensions/smallrye-reactive-messaging-amqp/runtime

✖ Failed to execute goal io.quarkus:quarkus-extension-maven-plugin:999-SNAPSHOT:extension-descriptor (generate-extension-descriptor) on project quarkus-messaging-amqp: The deployment artifact io.quarkus:quarkus-messaging-amqp-deployment::jar depends on the following Quarkus extension deployment artifacts whose corresponding runtime artifacts were not found among the dependencies of io.quarkus:quarkus-messaging-amqp:jar:999-SNAPSHOT: io.quarkus:quarkus-devservices-deployment::jar

📦 extensions/smallrye-reactive-messaging-mqtt/runtime

✖ Failed to execute goal io.quarkus:quarkus-extension-maven-plugin:999-SNAPSHOT:extension-descriptor (generate-extension-descriptor) on project quarkus-messaging-mqtt: The deployment artifact io.quarkus:quarkus-messaging-mqtt-deployment::jar depends on the following Quarkus extension deployment artifacts whose corresponding runtime artifacts were not found among the dependencies of io.quarkus:quarkus-messaging-mqtt:jar:999-SNAPSHOT: io.quarkus:quarkus-devservices-deployment::jar

📦 extensions/smallrye-reactive-messaging-pulsar/runtime

✖ Failed to execute goal io.quarkus:quarkus-extension-maven-plugin:999-SNAPSHOT:extension-descriptor (generate-extension-descriptor) on project quarkus-messaging-pulsar: The deployment artifact io.quarkus:quarkus-messaging-pulsar-deployment::jar depends on the following Quarkus extension deployment artifacts whose corresponding runtime artifacts were not found among the dependencies of io.quarkus:quarkus-messaging-pulsar:jar:999-SNAPSHOT: io.quarkus:quarkus-devservices-deployment::jar

📦 extensions/smallrye-reactive-messaging-rabbitmq/runtime

✖ Failed to execute goal io.quarkus:quarkus-extension-maven-plugin:999-SNAPSHOT:extension-descriptor (generate-extension-descriptor) on project quarkus-messaging-rabbitmq: The deployment artifact io.quarkus:quarkus-messaging-rabbitmq-deployment::jar depends on the following Quarkus extension deployment artifacts whose corresponding runtime artifacts were not found among the dependencies of io.quarkus:quarkus-messaging-rabbitmq:jar:999-SNAPSHOT: io.quarkus:quarkus-devservices-deployment::jar

Status for workflow Quarkus Documentation CI

This is the status report for running Quarkus Documentation CI on commit b60ab6d.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

@phillip-kruger another optiion you might want to offer is

quarkus.devservices."nginx".logging.enabled=true

in Mailpit I have this JbossLogConsumer https://github.com/quarkiverse/quarkus-mailpit/blob/main/deployment/src/main/java/io/quarkiverse/mailpit/deployment/JbossContainerLogConsumer.java

Which hooks into TestContainers to print out the logs of the container you just wire it in like this.

// forward the container logs
super.withLogConsumer(new JbossContainerLogConsumer(log).withPrefix(MailpitProcessor.FEATURE));

That is already there (I copied the one from Mailpit, thanks:) ) quarkus.devservices."nginx".capture-log=true

Nice! i don't know how i missed that!

Closing here. Discussed with @cescoffier - we are going to take another approach.