Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve quarkus run command #41380

Open
ia3andy opened this issue Jun 24, 2024 · 9 comments · May be fixed by #43649
Open

Improve quarkus run command #41380

ia3andy opened this issue Jun 24, 2024 · 9 comments · May be fixed by #43649
Assignees
Labels
area/cli Related to quarkus cli (not maven/gradle/etc.) area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins good first issue Good for newcomers help wanted Extra attention is needed kind/enhancement New feature or request

Comments

@ia3andy
Copy link
Contributor

ia3andy commented Jun 24, 2024

Description

Currently if not built quarkus run is failing.

If it's not build, it should build it before running, and, we should have quarkus run --clean to always rebuild.

Implementation ideas

Open

@ia3andy ia3andy added the kind/enhancement New feature or request label Jun 24, 2024
@ia3andy ia3andy added good first issue Good for newcomers help wanted Extra attention is needed area/cli Related to quarkus cli (not maven/gradle/etc.) area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins and removed triage/needs-triage labels Jun 24, 2024
@maxandersen
Copy link
Member

mind you; if we start requiring build to happen first it will force quarkus run to be slow as it first has to check.

I believe that's why it is assumed to not do the check.

@pn03
Copy link

pn03 commented Jun 25, 2024

Hi @ia3andy
I would like to contribute to this issue.

Implementation requirement is to add --clean (boolean) option to quarkus run to force build process, right?

@baranowb
Copy link

comment.

@ia3andy
Copy link
Contributor Author

ia3andy commented Jul 16, 2024

@pn03 sorry, I missed your message, what do you think of this issue instead #40471

It would be a very good feature

@pn03
Copy link

pn03 commented Jul 16, 2024

Hey @ia3andy , sure I'll take a look at that issue #40471

@abhishku
Copy link

If this is not picked, I'd like to do this one.

@ia3andy
Copy link
Contributor Author

ia3andy commented Aug 30, 2024

@baranowb any update on this?

@baranowb
Copy link

baranowb commented Sep 25, 2024

@ia3andy yep, a bit.
"it should build before run" - its tad problematic, since CLI only delegates and 'run' does(?) not support build options - it has no way of detecting custom build output, though it might not be that bad, its just part I did not look into. Unless its supposed to be simplistic build, however this could lead to a problem if user does build.
"build with --clean" - SImplest way here would be to switch prepare action from 'resources:resources' to 'install', better approach would be to refactor build command to be more of an utility. Though I got baffled why its defaults to 'resource:resource'
This week I will have bit more time to get hands on.
EDIT: different build target/file name, might be just misinterpretation on my part.

@baranowb baranowb linked a pull request Oct 2, 2024 that will close this issue
@baranowb
Copy link

baranowb commented Oct 2, 2024

Just to explain clean = false. In current impl there is sort of a bug/nonsense. Run command defaults to "resource:resource" and than "quarkus:run" in two distinct backend invocations.
Not sure why prep defaults to resource:resource, but thats minor thing. Major bug here is that in current setup, it means two triggers:
clean resources:resources
clean quarkus:run
This essentially cleans twice. So whatever resources:resources is supposed to do is null.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/cli Related to quarkus cli (not maven/gradle/etc.) area/devtools Issues/PR related to maven, gradle, platform and cli tooling/plugins good first issue Good for newcomers help wanted Extra attention is needed kind/enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants