Interest in automatically applying OpenRewrite best practices on pull requests?

[timtebeek]

Hi all! I was wondering if you'd be interested in having some best practices automatically applied to pull requests here. We added these friendly nudges to our own repositories a while ago, and they've really helped standardize our contributions. In practice what you'd get is one additional workflow run per PR, which comments code suggestions if it finds changes when applying best practices here.

You can see an example of such a comment here:

• Skip RemoveTestPrefix when calling a similarly named method openrewrite/rewrite-testing-frameworks#543 (comment)

The full list of best practices are described here.

• https://docs.openrewrite.org/recipes/recipes/openrewritebestpractices
• https://github.com/openrewrite/rewrite-recommendations/blob/main/src/main/resources/META-INF/rewrite/openrewrite.yml

An example of what this would look like for a Maven project like this one is here.

• Automatically review PRs with OpenRewrite recipe runs langchain4j/langchain4j#673

A more detailed write up of what we've done and why can be found here.

• https://www.moderne.ai/blog/stop-breaking-ci-annotate-prs-with-openrewrite-recipe-fixes-as-quality-gate

I hope that's of use to you here; I'd be happy to open a PR if you'd indeed be open to adopting this practice.

[timtebeek]

As a first step this change would allow running those best practices once as a one-off:
main...timtebeek:quarkus-updates:best-practices-via-rewrite.yml

Then from there we can review any new issues coming in on PRs automatically, with a convenient local option to prevent these through the run button shown here.

[ia3andy]

Thanks @timtebeek!

@gsmet wdyt?