primitives: ensure key uniqueness for ResultsDict #8
Comments
JulioLoayzaM
changed the title
JulioLoayzaM
added a commit
that referenced
this issue
Sep 3, 2024
Some tests may create different Results instances using the same set of parameters, which would lead to a key conflict in ResultsDict. To solve this, we add the possibility to add other values to the key created by the add method. Issue: #8
JulioLoayzaM
added a commit
that referenced
this issue
Sep 3, 2024
Hard-coding the keys in the returned ResultsDict led to a conflict when testing more than one set of parameters (e.g. SHA-224 and SHA-256). So we use Results.new and ResultsDict.add, along with the new extra_values option, to ensure that keys are unique for a given run. This means that it still does not support combining the results of testing two different implementations of the same algorithm. Issue: #8
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Related to #7, Wycheproof tests use a single key for any key length, which may lead to overwriting if testing them separately. The key should depend on the key length being tested to prevent this.
The text was updated successfully, but these errors were encountered: