Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quarkus LTS support #831

Open
brice-laurencin opened this issue Oct 25, 2024 · 14 comments
Open

Quarkus LTS support #831

brice-laurencin opened this issue Oct 25, 2024 · 14 comments
Labels
area:client This item is related to the client extension area:server This item is related to the server extension

Comments

@brice-laurencin
Copy link
Contributor

With quarkus now supporting LTS versions, it feels like the extension should support those LTS versions for their support timeframe.

I clearly don't have any idea how it could move forward.
But I'd be happy to help if I can.

@hbelmiro
Copy link
Contributor

We'll probably have multiple branches for each Quarkus version, like when we used to support Quarkus 3 and 2.

@ricardozanini @gastaldi thoughts?

@gastaldi
Copy link
Member

@hbelmiro exactly. Some projects like https://github.com/quarkiverse/quarkus-artemis already do this

@ricardozanini
Copy link
Member

@hbelmiro Yes, we have to branch from the main, roll back to LTS, and release a new version from this branch. We can have the same number but with a suffix like 1.2.3-lts.

@brice-laurencin I can create the branch. Can you work on a patch to follow the LTS in this new branch?

@ricardozanini ricardozanini added area:server This item is related to the server extension area:client This item is related to the client extension labels Oct 25, 2024
@brice-laurencin
Copy link
Contributor Author

I can try, but I'm not sure I see all that must be done.
As you mentioned, I'd go from main and downgrade the quarkus version.

(And I might not be able to do this this week, but next week will be fine)

@jota-coelho
Copy link

With quarkus now supporting LTS versions, it feels like the extension should support those LTS versions for their support timeframe.

I clearly don't have any idea how it could move forward. But I'd be happy to help if I can.

Hello! I’d like to emphasize that I also need to migrate to the LTS version, so this update would be very helpful.

@ricardozanini
Copy link
Member

@jota-coelho We are open to contributions.

I created the main-lts branch here: https://github.com/quarkiverse/quarkus-openapi-generator/tree/main-lts

Any PRs should be opened there, and the documentation should be updated to tell users about it. Once it's done, I can do the release.

@brice-laurencin once you open the PR, we can discuss more details if needed.

@brice-laurencin
Copy link
Contributor Author

brice-laurencin commented Oct 29, 2024

I think we need a branch per current LTS, mentioning the targeted version.
there are 2 LTS at the moment, and with 12 months of support, we could have up to 3 I suppose.

@ricardozanini
Copy link
Member

@brice-laurencin I don't think we have the resources to keep up with the three branches. We can keep up with the latest LTS.

@brice-laurencin
Copy link
Contributor Author

@ricardozanini technically, current main-lts references Quarkus 3.15.1, so it's already linking the latest LTS patch.

So I suppose everything is good?
Maybe we need to find a proper version pattern for those versions.

@ricardozanini
Copy link
Member

ricardozanini commented Nov 4, 2024

We can support the older LTS instead. I think it will be more helpful for the community.

The version pattern could be 1.2.3-lts.

@hbelmiro
Copy link
Contributor

hbelmiro commented Nov 4, 2024

@ricardozanini
Copy link
Member

@hbelmiro @brice-laurencin the idea is to support an old LTS, in this case Quarkus 3.8 LTS.

@hbelmiro
Copy link
Contributor

hbelmiro commented Nov 4, 2024

My point is that we're close to supporting 3.16 in main. Once we do that, I'm assuming we would support 3.15 in main-lts.
That said, it's probably better just to wait for 3.16 than invest time to support 3.8 just for a few days.

@ricardozanini
Copy link
Member

@hbelmiro yes, agreed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:client This item is related to the client extension area:server This item is related to the server extension
Projects
None yet
Development

No branches or pull requests

5 participants