-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CtrlSpec
add support for symbolic Shaped
control values
#1168
Comments
What is missing? |
Requires some fixes to how shapes and num_qubits are computed to work with symbolics, and updated type hints. Didn't want to over-complicate #1155, so this can be done in a follow-up. |
@anurudhp @mpharrigan I am finding that MultiControlX(symbolic n).controlled() is causing issues. This issue was linked in the build_call_graph function for MultiControlX with symbolic cvs - what's required to fix this? Code to reproduce: n = sympy.symbols('n', integer=True) |
Awesome! That will unblock #1489. Equals.controlled breaks down to that case and is causing issues with the symbolic cost unit test. |
Useful when we know the number of controls, e.g. #1155 (comment)
Related #786
The text was updated successfully, but these errors were encountered: